refactor: clean up unused config options

conf/configuration.go

@@ -23,10 +23,7 @@ type nd struct {
 	IgnoredArticles string `default:"The El La Los Las Le Les Os As O A"`
 	IndexGroups     string `default:"A B C D E F G H I J K L M N O P Q R S T U V W X-Z(XYZ) [Unknown]([)"`
 
-	EnableDownsampling      bool   `default:"false"`
-	MaxBitRate              int    `default:"0"`
-	MaxTranscodingCacheSize int64  `default:"100"` // in MB
-	DownsampleCommand       string `default:"ffmpeg -i %s -map 0:0 -b:a %bk -v 0 -f mp3 -"`
+	TranscodingCacheSize int64  `default:"100"` // in MB
 	ProbeCommand         string `default:"ffmpeg -i %s -f ffmetadata"`
 
 	// DevFlags. These are used to enable/disable debugging and incomplete features

engine/media_streamer.go

@@ -198,7 +198,7 @@ func getFinalCachedSize(r fscache.ReadAtCloser) int64 {
 }
 
 func NewTranscodingCache() (fscache.Cache, error) {
-	lru := fscache.NewLRUHaunter(0, conf.Server.MaxTranscodingCacheSize*1024*1024, 10*time.Minute)
+	lru := fscache.NewLRUHaunter(0, conf.Server.TranscodingCacheSize*1024*1024, 10*time.Minute)
 	h := fscache.NewLRUHaunterStrategy(lru)
 	cacheFolder := filepath.Join(conf.Server.DataFolder, consts.CacheDir)
 	fs, err := fscache.NewFs(cacheFolder, 0755)

engine/media_streamer_test.go

@@ -7,7 +7,6 @@ import (
 	"os"
 	"strings"
 
-	"github.com/deluan/navidrome/conf"
 	"github.com/deluan/navidrome/log"
 	"github.com/deluan/navidrome/model"
 	"github.com/deluan/navidrome/persistence"
@@ -31,7 +30,6 @@ var _ = Describe("MediaStreamer", func() {
 	})
 
 	BeforeEach(func() {
-		conf.Server.EnableDownsampling = true
 		ds = &persistence.MockDataStore{MockedTranscoding: &mockTranscodingRepository{}}
 		ds.MediaFile(ctx).(*persistence.MockMediaFile).SetData(`[{"id": "123", "path": "tests/fixtures/test.mp3", "suffix": "mp3", "bitRate": 128, "duration": 257.0}]`, 1)
 		streamer = NewMediaStreamer(ds, ffmpeg, cache)