Use userId in player, other fixes (#3182)

* [bugfix] player: use userId, other fixes

This PR primarily resolves #1928 by switching the foreign key of `player` from `user.user_name` to `user.id`.
There are also a few other fixes/changes:

- For some bizarre reason, `ip_address` is never returned from `read`/`get`. Change the field to `ip`, which works. Somehow
- Update `players_test.go` mock to also check for user agent, replicating the actual code
- Update `player_repository.go` `isPermitted` to check user id. I don't know how this worked before...
- tests!
- a few places referred to `typ`, when it is really `userAgent`. Change the field names

* baseRequest -> selectPlayer

* remove comment

* update migration, make all of persistence foreign key enabled

* maybe don't forget to save the file first

model/player.go

@@ -5,12 +5,14 @@ import (
 )
 
 type Player struct {
+	Username string `structs:"-" json:"userName"`
+
 	ID              string    `structs:"id" json:"id"`
 	Name            string    `structs:"name" json:"name"`
 	UserAgent       string    `structs:"user_agent" json:"userAgent"`
-	UserName        string    `structs:"user_name" json:"userName"`
+	UserId          string    `structs:"user_id" json:"userId"`
 	Client          string    `structs:"client" json:"client"`
-	IPAddress       string    `structs:"ip_address" json:"ipAddress"`
+	IP              string    `structs:"ip" json:"ip"`
 	LastSeen        time.Time `structs:"last_seen" json:"lastSeen"`
 	TranscodingId   string    `structs:"transcoding_id" json:"transcodingId"`
 	MaxBitRate      int       `structs:"max_bit_rate" json:"maxBitRate"`
@@ -22,7 +24,7 @@ type Players []Player
 
 type PlayerRepository interface {
 	Get(id string) (*Player, error)
-	FindMatch(userName, client, typ string) (*Player, error)
+	FindMatch(userId, client, userAgent string) (*Player, error)
 	Put(p *Player) error
 	// TODO: Add CountAll method. Useful at least for metrics.
 }