mirror of
https://github.com/navidrome/navidrome.git
synced 2025-04-01 19:47:37 +03:00
* fix(scanner): remove transactions where they are not strictly needed Signed-off-by: Deluan <deluan@navidrome.org> * fix(server): force setStar transaction to start as IMMEDIATE Signed-off-by: Deluan <deluan@navidrome.org> * fix(server): encapsulated way to upgrade tx to write mode Signed-off-by: Deluan <deluan@navidrome.org> * fix(server): use tx immediate for some playlist endpoints Signed-off-by: Deluan <deluan@navidrome.org> * make more transactions immediate (#3759) --------- Signed-off-by: Deluan <deluan@navidrome.org> Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
192 lines
6.2 KiB
Go
192 lines
6.2 KiB
Go
package persistence
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"reflect"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/db"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/utils/chain"
|
|
"github.com/pocketbase/dbx"
|
|
)
|
|
|
|
type SQLStore struct {
|
|
db dbx.Builder
|
|
}
|
|
|
|
func New(conn *sql.DB) model.DataStore {
|
|
return &SQLStore{db: dbx.NewFromDB(conn, db.Driver)}
|
|
}
|
|
|
|
func (s *SQLStore) Album(ctx context.Context) model.AlbumRepository {
|
|
return NewAlbumRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Artist(ctx context.Context) model.ArtistRepository {
|
|
return NewArtistRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) MediaFile(ctx context.Context) model.MediaFileRepository {
|
|
return NewMediaFileRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Library(ctx context.Context) model.LibraryRepository {
|
|
return NewLibraryRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Folder(ctx context.Context) model.FolderRepository {
|
|
return newFolderRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Genre(ctx context.Context) model.GenreRepository {
|
|
return NewGenreRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Tag(ctx context.Context) model.TagRepository {
|
|
return NewTagRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) PlayQueue(ctx context.Context) model.PlayQueueRepository {
|
|
return NewPlayQueueRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Playlist(ctx context.Context) model.PlaylistRepository {
|
|
return NewPlaylistRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Property(ctx context.Context) model.PropertyRepository {
|
|
return NewPropertyRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Radio(ctx context.Context) model.RadioRepository {
|
|
return NewRadioRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) UserProps(ctx context.Context) model.UserPropsRepository {
|
|
return NewUserPropsRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Share(ctx context.Context) model.ShareRepository {
|
|
return NewShareRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) User(ctx context.Context) model.UserRepository {
|
|
return NewUserRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Transcoding(ctx context.Context) model.TranscodingRepository {
|
|
return NewTranscodingRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Player(ctx context.Context) model.PlayerRepository {
|
|
return NewPlayerRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) ScrobbleBuffer(ctx context.Context) model.ScrobbleBufferRepository {
|
|
return NewScrobbleBufferRepository(ctx, s.getDBXBuilder())
|
|
}
|
|
|
|
func (s *SQLStore) Resource(ctx context.Context, m interface{}) model.ResourceRepository {
|
|
switch m.(type) {
|
|
case model.User:
|
|
return s.User(ctx).(model.ResourceRepository)
|
|
case model.Transcoding:
|
|
return s.Transcoding(ctx).(model.ResourceRepository)
|
|
case model.Player:
|
|
return s.Player(ctx).(model.ResourceRepository)
|
|
case model.Artist:
|
|
return s.Artist(ctx).(model.ResourceRepository)
|
|
case model.Album:
|
|
return s.Album(ctx).(model.ResourceRepository)
|
|
case model.MediaFile:
|
|
return s.MediaFile(ctx).(model.ResourceRepository)
|
|
case model.Genre:
|
|
return s.Genre(ctx).(model.ResourceRepository)
|
|
case model.Playlist:
|
|
return s.Playlist(ctx).(model.ResourceRepository)
|
|
case model.Radio:
|
|
return s.Radio(ctx).(model.ResourceRepository)
|
|
case model.Share:
|
|
return s.Share(ctx).(model.ResourceRepository)
|
|
case model.Tag:
|
|
return s.Tag(ctx).(model.ResourceRepository)
|
|
}
|
|
log.Error("Resource not implemented", "model", reflect.TypeOf(m).Name())
|
|
return nil
|
|
}
|
|
|
|
func (s *SQLStore) WithTx(block func(tx model.DataStore) error, scope ...string) error {
|
|
var msg string
|
|
if len(scope) > 0 {
|
|
msg = scope[0]
|
|
}
|
|
start := time.Now()
|
|
conn, inTx := s.db.(*dbx.DB)
|
|
if !inTx {
|
|
log.Trace("Nested Transaction started", "scope", msg)
|
|
conn = dbx.NewFromDB(db.Db(), db.Driver)
|
|
} else {
|
|
log.Trace("Transaction started", "scope", msg)
|
|
}
|
|
return conn.Transactional(func(tx *dbx.Tx) error {
|
|
newDb := &SQLStore{db: tx}
|
|
err := block(newDb)
|
|
if !inTx {
|
|
log.Trace("Nested Transaction finished", "scope", msg, "elapsed", time.Since(start), err)
|
|
} else {
|
|
log.Trace("Transaction finished", "scope", msg, "elapsed", time.Since(start), err)
|
|
}
|
|
return err
|
|
})
|
|
}
|
|
|
|
func (s *SQLStore) WithTxImmediate(block func(tx model.DataStore) error, scope ...string) error {
|
|
ctx := context.Background()
|
|
return s.WithTx(func(tx model.DataStore) error {
|
|
// Workaround to force the transaction to be upgraded to immediate mode to avoid deadlocks
|
|
// See https://berthub.eu/articles/posts/a-brief-post-on-sqlite3-database-locked-despite-timeout/
|
|
_ = tx.Property(ctx).Put("tmp_lock_flag", "")
|
|
defer func() {
|
|
_ = tx.Property(ctx).Delete("tmp_lock_flag")
|
|
}()
|
|
|
|
return block(tx)
|
|
}, scope...)
|
|
}
|
|
|
|
func (s *SQLStore) GC(ctx context.Context) error {
|
|
trace := func(ctx context.Context, msg string, f func() error) func() error {
|
|
return func() error {
|
|
start := time.Now()
|
|
err := f()
|
|
log.Debug(ctx, "GC: "+msg, "elapsed", time.Since(start), err)
|
|
return err
|
|
}
|
|
}
|
|
|
|
err := chain.RunSequentially(
|
|
trace(ctx, "purge empty albums", func() error { return s.Album(ctx).(*albumRepository).purgeEmpty() }),
|
|
trace(ctx, "purge empty artists", func() error { return s.Artist(ctx).(*artistRepository).purgeEmpty() }),
|
|
trace(ctx, "purge empty folders", func() error { return s.Folder(ctx).(*folderRepository).purgeEmpty() }),
|
|
trace(ctx, "clean album annotations", func() error { return s.Album(ctx).(*albumRepository).cleanAnnotations() }),
|
|
trace(ctx, "clean artist annotations", func() error { return s.Artist(ctx).(*artistRepository).cleanAnnotations() }),
|
|
trace(ctx, "clean media file annotations", func() error { return s.MediaFile(ctx).(*mediaFileRepository).cleanAnnotations() }),
|
|
trace(ctx, "clean media file bookmarks", func() error { return s.MediaFile(ctx).(*mediaFileRepository).cleanBookmarks() }),
|
|
trace(ctx, "purge non used tags", func() error { return s.Tag(ctx).(*tagRepository).purgeUnused() }),
|
|
trace(ctx, "remove orphan playlist tracks", func() error { return s.Playlist(ctx).(*playlistRepository).removeOrphans() }),
|
|
)
|
|
if err != nil {
|
|
log.Error(ctx, "Error tidying up database", err)
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (s *SQLStore) getDBXBuilder() dbx.Builder {
|
|
if s.db == nil {
|
|
return dbx.NewFromDB(db.Db(), db.Driver)
|
|
}
|
|
return s.db
|
|
}
|