mirror of
https://github.com/navidrome/navidrome.git
synced 2025-04-03 20:47:35 +03:00
814161d78d
* draft commit * time to fight pipeline * round 2 changes * remove unnecessary line * fight taglib. again * make taglib work again??? * add id3 tags * taglib 1.12 vs 1.13 * use int instead for windows * store as json now * add migration, more tests * support repeated line, multiline * fix ms and support .m, .mm, .mmm * address some concerns, make cpp a bit safer * separate responses from model * remove [:] * Add trace log * Try to unblock pipeline * Fix merge errors * Fix SIGSEGV error (proper handling of empty frames) * Add fallback artist/title to structured lyrics * Rename conflicting named vars * Fix tests * Do we still need ffmpeg in the pipeline? * Revert "Do we still need ffmpeg in the pipeline?" Yes we do. This reverts commit87df7f6df7. * Does this passes now, with a newer ffmpeg version? * Revert "Does this passes now, with a newer ffmpeg version?" No, it does not :( This reverts commit372eb4b0ae. * My OCD made me do it :P --------- Co-authored-by: Deluan Quintão <deluan@navidrome.org>
104 lines
3.5 KiB
Go
104 lines
3.5 KiB
Go
package model_test
|
|
|
|
import (
|
|
. "github.com/navidrome/navidrome/model"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("ToLyrics", func() {
|
|
It("should parse tags with spaces", func() {
|
|
num := int64(1551)
|
|
lyrics, err := ToLyrics("xxx", "[offset: 1551 ]\n[ti: A title ]\n[ar: An artist ]\n[00:00.00]Hi there")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.DisplayArtist).To(Equal("An artist"))
|
|
Expect(lyrics.DisplayTitle).To(Equal("A title"))
|
|
Expect(lyrics.Offset).To(Equal(&num))
|
|
})
|
|
|
|
It("Should ignore bad offset", func() {
|
|
lyrics, err := ToLyrics("xxx", "[offset: NotANumber ]\n[00:00.00]Hi there")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Offset).To(BeNil())
|
|
})
|
|
|
|
It("should accept lines with no text and weird times", func() {
|
|
a, b, c, d := int64(0), int64(10040), int64(40000), int64(1000*60*60)
|
|
lyrics, err := ToLyrics("xxx", "[00:00.00]Hi there\n\n\n[00:10.040]\n[00:40]Test\n[01:00:00]late")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "Hi there"},
|
|
{Start: &b, Value: ""},
|
|
{Start: &c, Value: "Test"},
|
|
{Start: &d, Value: "late"},
|
|
}))
|
|
})
|
|
|
|
It("Should support multiple timestamps per line", func() {
|
|
a, b, c, d := int64(0), int64(10000), int64(13*60*1000), int64(1000*60*60*51)
|
|
lyrics, err := ToLyrics("xxx", "[00:00.00] [00:10.00]Repeated\n[13:00][51:00:00.00]")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "Repeated"},
|
|
{Start: &b, Value: "Repeated"},
|
|
{Start: &c, Value: ""},
|
|
{Start: &d, Value: ""},
|
|
}))
|
|
})
|
|
|
|
It("Should support parsing multiline string", func() {
|
|
a, b := int64(0), int64(10*60*1000+1)
|
|
lyrics, err := ToLyrics("xxx", "[00:00.00]This is\na multiline \n\n [:0] string\n[10:00.001]This is\nalso one")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "This is\na multiline\n\n[:0] string"},
|
|
{Start: &b, Value: "This is\nalso one"},
|
|
}))
|
|
})
|
|
|
|
It("Does not match timestamp in middle of line", func() {
|
|
lyrics, err := ToLyrics("xxx", "This could [00:00:00] be a synced file")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeFalse())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Value: "This could [00:00:00] be a synced file"},
|
|
}))
|
|
})
|
|
|
|
It("Allows timestamp in middle of line if also at beginning", func() {
|
|
a, b := int64(0), int64(1000)
|
|
lyrics, err := ToLyrics("xxx", " [00:00] This is [00:00:00] be a synced file\n [00:01]Line 2")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "This is [00:00:00] be a synced file"},
|
|
{Start: &b, Value: "Line 2"},
|
|
}))
|
|
})
|
|
|
|
It("Ignores lines in synchronized lyric prior to first timestamp", func() {
|
|
a := int64(0)
|
|
lyrics, err := ToLyrics("xxx", "This is some prelude\nThat doesn't\nmatter\n[00:00]Text")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "Text"},
|
|
}))
|
|
})
|
|
|
|
It("Handles all possible ms cases", func() {
|
|
a, b, c := int64(1), int64(10), int64(100)
|
|
lyrics, err := ToLyrics("xxx", "[00:00.001]a\n[00:00.01]b\n[00:00.1]c")
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(lyrics.Synced).To(BeTrue())
|
|
Expect(lyrics.Line).To(Equal([]Line{
|
|
{Start: &a, Value: "a"},
|
|
{Start: &b, Value: "b"},
|
|
{Start: &c, Value: "c"},
|
|
}))
|
|
})
|
|
})
|