mirrors/ntex-extras
1
0
Fork 0
mirror of https://github.com/ntex-rs/ntex-extras.git synced 2025-04-04 21:38:01 +03:00
Code Issues Projects Releases Packages Wiki Activity

refactor(ntex-files): Clippy

Browse source
This commit is contained in:
leon3s 2023-04-09 13:23:03 +02:00
parent c6e0dfbeb4
commit bd3036f9da
No known key found for this signature in database
GPG key ID: 6579DBA24F68AD88
3 changed files with 12 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ntex-files/src/file_header/content_disposition.rs
View file

@ -93,9 +93,9 @@ impl Header for ContentDisposition {
};
let mut cd = ContentDisposition {
disposition: if unicase::eq_ascii(&*disposition, "inline") {
disposition: if unicase::eq_ascii(disposition, "inline") {
DispositionType::Inline
} else if unicase::eq_ascii(&*disposition, "attachment") {
} else if unicase::eq_ascii(disposition, "attachment") {
DispositionType::Attachment
} else {
DispositionType::Ext(disposition.to_owned())
@ -118,13 +118,13 @@ impl Header for ContentDisposition {
return Err(error::Error::Header);
};
cd.parameters.push(if unicase::eq_ascii(&*key, "filename") {
cd.parameters.push(if unicase::eq_ascii(key, "filename") {
DispositionParam::Filename(
Charset::Ext("UTF-8".to_owned()),
None,
val.trim_matches('"').as_bytes().to_owned(),
)
} else if unicase::eq_ascii(&*key, "filename*") {
} else if unicase::eq_ascii(key, "filename*") {
let extended_value = parse_extended_value(val)?;
DispositionParam::Filename(
extended_value.charset,

2
ntex-files/src/file_header/entity.rs
View file

@ -7,7 +7,7 @@ use std::str::FromStr;
/// 2. in the range `%x23` to `%x7E`, or
/// 3. above `%x80`
fn check_slice_validity(slice: &str) -> bool {
slice.bytes().all(|c| c == b'\x21' || (c >= b'\x23' && c <= b'\x7e') | (c >= b'\x80'))
slice.bytes().all(|c| c == b'\x21' || (b'\x23'..=b'\x7e').contains(&c) | (c >= b'\x80'))
}
/// An entity tag, defined in [RFC7232](https://tools.ietf.org/html/rfc7232#section-2.3)

20
ntex-files/src/file_header/method.rs
View file

@ -61,10 +61,7 @@ impl Method {
/// See [the spec](https://tools.ietf.org/html/rfc7231#section-4.2.1)
/// for more words.
pub fn safe(&self) -> bool {
match *self {
Get | Head | Options | Trace => true,
_ => false,
}
matches!(*self, Get | Head | Options | Trace)
}
/// Whether a method is considered "idempotent", meaning the request has
@ -76,10 +73,7 @@ impl Method {
if self.safe() {
true
} else {
match *self {
Put | Delete => true,
_ => false,
}
matches!(*self, Put | Delete)
}
}
}
@ -200,15 +194,15 @@ mod tests {
#[test]
fn test_safe() {
assert_eq!(true, Get.safe());
assert_eq!(false, Post.safe());
assert!(Get.safe());
assert!(!Post.safe());
}
#[test]
fn test_idempotent() {
assert_eq!(true, Get.idempotent());
assert_eq!(true, Put.idempotent());
assert_eq!(false, Post.idempotent());
assert!(Get.idempotent());
assert!(Put.idempotent());
assert!(!Post.idempotent());
}
#[test]