time::sleep() always sleeps one tick (16 millis) even for 0 millis

ntex-util/CHANGES.md

@@ -1,5 +1,9 @@
 # Changes
 
+## [0.1.14] - 2022-02-18
+
+* time::sleep() always sleeps one tick (16 millis) even for 0 millis
+
 ## [0.1.13] - 2022-01-28
 
 * Add Default impl to oneshots pool

ntex-util/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-util"
-version = "0.1.13"
+version = "0.1.14"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "Utilities for ntex framework"
 keywords = ["network", "framework", "async", "futures"]
@@ -29,6 +29,6 @@ pin-project-lite = "0.2.6"
 
 [dev-dependencies]
 ntex = { version = "0.5", features = ["tokio"] }
-ntex-bytes = "0.1.9"
+ntex-bytes = "0.1.14"
 ntex-macros = "0.1.3"
 futures-util = { version = "0.3", default-features = false, features = ["alloc"] }

ntex-util/src/time/mod.rs

@@ -1,5 +1,5 @@
 //! Utilities for tracking time.
-use std::{future::Future, pin::Pin, task, task::Poll};
+use std::{cmp, future::Future, pin::Pin, task, task::Poll};
 
 mod types;
 mod wheel;
@@ -11,7 +11,8 @@ pub use self::wheel::{now, query_system_time, system_time, TimerHandle};
 ///
 /// No work is performed while awaiting on the sleep future to complete. `Sleep`
 /// operates at 16 millisecond granularity and should not be used for tasks that
-/// require high-resolution timers.
+/// require high-resolution timers. `Sleep` sleeps at least one tick (16 millis)
+/// even if 0 millis duration is used.
 #[inline]
 pub fn sleep<T: Into<Millis>>(dur: T) -> Sleep {
     Sleep::new(dur.into())
@@ -81,7 +82,7 @@ impl Sleep {
     #[inline]
     pub fn new(duration: Millis) -> Sleep {
         Sleep {
-            hnd: TimerHandle::new(duration.0 as u64),
+            hnd: TimerHandle::new(cmp::max(duration.0, 1) as u64),
         }
     }
 
@@ -308,6 +309,19 @@ mod tests {
         assert!(second_time - first_time >= time::Duration::from_millis(wait_time as u64));
     }
 
+    #[ntex_macros::rt_test2]
+    async fn test_sleep_0() {
+        let first_time = now();
+        sleep(Millis(0)).await;
+        let second_time = now();
+        assert!(second_time - first_time >= time::Duration::from_millis(1));
+
+        let first_time = now();
+        sleep(Millis(1)).await;
+        let second_time = now();
+        assert!(second_time - first_time >= time::Duration::from_millis(1));
+    }
+
     #[ntex_macros::rt_test2]
     async fn test_interval() {
         let mut int = interval(Millis(250));

ntex/CHANGES.md

@@ -1,6 +1,6 @@
 # Changes
 
-## [0.5.15] - 2022-02-xx
+## [0.5.15] - 2022-02-18
 
 * web: Fix unsupported web ws handling
 

ntex/Cargo.toml

@@ -52,7 +52,7 @@ ntex-codec = "0.6.2"
 ntex-router = "0.5.1"
 ntex-service = "0.3.1"
 ntex-macros = "0.1.3"
-ntex-util = "0.1.13"
+ntex-util = "0.1.14"
 ntex-bytes = "0.1.14"
 ntex-tls = "0.1.3"
 ntex-rt = "0.4.3"