mirrors/ntex
1
0
Fork 0
mirror of https://github.com/ntex-rs/ntex.git synced 2025-04-03 21:07:39 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix HeaderMap append order (#145)

Browse source
This commit is contained in:
Alex Orlenko 2022-11-24 13:15:19 +00:00 • committed by GitHub
parent 60d7646ba4
commit ce16bfa1b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

25
ntex-http/src/map.rs
View file

@ -48,8 +48,9 @@ impl Value {
fn append(&mut self, val: HeaderValue) {
match self {
Value::One(_) => {
let data = std::mem::replace(self, Value::Multi(vec![val]));
Value::One(prev_val) => {
let prev_val = std::mem::replace(prev_val, val);
let data = std::mem::replace(self, Value::Multi(vec![prev_val]));
match data {
Value::One(val) => self.append(val),
Value::Multi(_) => unreachable!(),
@ -535,7 +536,7 @@ impl<'a> Iterator for Iter<'a> {
#[cfg(test)]
mod tests {
use super::*;
use crate::header::CONTENT_TYPE;
use crate::header::{ACCEPT_ENCODING, CONTENT_TYPE};
#[test]
fn test_from_iter() {
@ -593,4 +594,22 @@ mod tests {
m.remove("content-type");
assert!(m.is_empty());
}
#[test]
fn test_append() {
let mut map = HeaderMap::new();
map.append(ACCEPT_ENCODING, HeaderValue::from_static("gzip"));
map.append(ACCEPT_ENCODING, HeaderValue::from_static("br"));
map.append(ACCEPT_ENCODING, HeaderValue::from_static("deflate"));
assert_eq!(
map.get_all(ACCEPT_ENCODING).collect::<Vec<_>>(),
vec![
&HeaderValue::from_static("gzip"),
&HeaderValue::from_static("br"),
&HeaderValue::from_static("deflate"),
]
);
}
}