mirrors/ntex
1
0
Fork 0
mirror of https://github.com/ntex-rs/ntex.git synced 2025-04-05 13:57:39 +03:00
Code Issues Projects Releases Packages Wiki Activity

Optimize readiness handling (#457)

Browse source
This commit is contained in:
Nikolay Kim 2024-11-04 18:18:15 +05:00 • committed by GitHub
parent c26b336fe5
commit ddbc4a722d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 46 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ntex-service/CHANGES.md
View file

@ -1,6 +1,10 @@
# Changes # Changes
## [3.3.0] - 2024-11-02 ## [3.3.1] - 2024-11-04
* Optimize readiness handling
## [3.3.0] - 2024-11-04
* Added Service::not_ready() method * Added Service::not_ready() method

2
ntex-service/Cargo.toml
View file

@ -1,6 +1,6 @@
[package] [package]
name = "ntex-service" name = "ntex-service"
version = "3.3.0" version = "3.3.1"
authors = ["ntex contributors <team@ntex.rs>"] authors = ["ntex contributors <team@ntex.rs>"]
description = "ntex service" description = "ntex service"
keywords = ["network", "framework", "async", "futures"] keywords = ["network", "framework", "async", "futures"]

13
ntex-service/src/ctx.rs
View file

@ -56,8 +56,14 @@ impl WaitersRef {
} }
pub(crate) fn register(&self, idx: u32, cx: &mut Context<'_>) { pub(crate) fn register(&self, idx: u32, cx: &mut Context<'_>) {
let wakers = self.get_wakers();
if let Some(last) = wakers.last() {
if idx == *last {
return;
}
}
wakers.push(idx);
self.get()[idx as usize] = Some(cx.waker().clone()); self.get()[idx as usize] = Some(cx.waker().clone());
self.get_wakers().push(idx);
} }
pub(crate) fn register_unready(&self, cx: &mut Context<'_>) { pub(crate) fn register_unready(&self, cx: &mut Context<'_>) {
@ -66,9 +72,9 @@ impl WaitersRef {
} }
pub(crate) fn notify(&self) { pub(crate) fn notify(&self) {
let indexes = self.get();
let wakers = self.get_wakers(); let wakers = self.get_wakers();
if !wakers.is_empty() {
let indexes = self.get();
for idx in wakers.drain(..) { for idx in wakers.drain(..) {
if let Some(item) = indexes.get_mut(idx as usize) { if let Some(item) = indexes.get_mut(idx as usize) {
if let Some(waker) = item.take() { if let Some(waker) = item.take() {
@ -76,6 +82,7 @@ impl WaitersRef {
} }
} }
} }
}
self.cur.set(u32::MAX); self.cur.set(u32::MAX);
} }

18
ntex-service/src/pipeline.rs
View file

@ -420,7 +420,10 @@ where
let mut slf = self.as_mut(); let mut slf = self.as_mut();
if slf.pl.state.waiters.can_check(slf.pl.index, cx) { if slf.pl.state.waiters.can_check(slf.pl.index, cx) {
if let Some(ref mut fut) = slf.fut { if slf.fut.is_none() {
slf.fut = Some((slf.f)(slf.pl));
}
let fut = slf.fut.as_mut().unwrap();
match unsafe { Pin::new_unchecked(fut) }.poll(cx) { match unsafe { Pin::new_unchecked(fut) }.poll(cx) {
Poll::Pending => { Poll::Pending => {
slf.pl.state.waiters.register(slf.pl.index, cx); slf.pl.state.waiters.register(slf.pl.index, cx);
@ -432,10 +435,6 @@ where
Poll::Ready(res) Poll::Ready(res)
} }
} }
} else {
slf.fut = Some((slf.f)(slf.pl));
self.poll(cx)
}
} else { } else {
Poll::Pending Poll::Pending
} }
@ -460,7 +459,10 @@ where
fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<T> { fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<T> {
let mut slf = self.as_mut(); let mut slf = self.as_mut();
if let Some(ref mut fut) = slf.fut { if slf.fut.is_none() {
slf.fut = Some((slf.f)(slf.pl));
}
let fut = slf.fut.as_mut().unwrap();
match unsafe { Pin::new_unchecked(fut) }.poll(cx) { match unsafe { Pin::new_unchecked(fut) }.poll(cx) {
Poll::Pending => { Poll::Pending => {
slf.pl.state.waiters.register_unready(cx); slf.pl.state.waiters.register_unready(cx);
@ -472,9 +474,5 @@ where
Poll::Ready(res) Poll::Ready(res)
} }
} }
} else {
slf.fut = Some((slf.f)(slf.pl));
self.poll(cx)
}
} }
} }