clippy

ntex-router/src/tree.rs

@@ -265,7 +265,7 @@ impl Tree {
                         base_skip,
                     )
                 })
-                .filter_map(|x| x)
+                .flatten()
                 .next();
 
             return if let Some((val, skip)) = res {
@@ -519,7 +519,7 @@ impl Tree {
                                                     base_skip,
                                                 )
                                             })
-                                            .filter_map(|x| x)
+                                            .flatten()
                                             .next()
                                         {
                                             return Some(res);
@@ -559,7 +559,7 @@ impl Tree {
                                 base_skip,
                             )
                         })
-                        .filter_map(|x| x)
+                        .flatten()
                         .next();
                 } else {
                     path = &path[idx + 1..];

ntex-service/src/map_err.rs

@@ -184,7 +184,7 @@ where
     F: Fn(A::Error) -> E,
 {
     fn new(fut: A::Future, f: F) -> Self {
-        MapErrServiceFuture { f, fut }
+        MapErrServiceFuture { fut, f }
     }
 }
 

ntex/src/framed/write.rs

@@ -53,7 +53,7 @@ where
             Shutdown::None,
         );
 
-        Self { io, st, state }
+        Self { st, io, state }
     }
 }
 
@@ -165,7 +165,7 @@ where
 
                     // disconnect timeout
                     if let Some(ref mut delay) = delay {
-                        if let Poll::Pending = Pin::new(delay).poll(cx) {
+                        if Pin::new(delay).poll(cx).is_pending() {
                             return Poll::Pending;
                         }
                     }

ntex/src/http/client/ws.rs

@@ -419,8 +419,8 @@ where
 
         Self {
             io,
-            codec,
             state,
+            codec,
             res,
         }
     }

ntex/src/http/h1/service.rs

@@ -425,11 +425,7 @@ where
     }
 
     fn call(&self, (io, addr): Self::Request) -> Self::Future {
-        let on_connect = if let Some(ref on_connect) = self.on_connect {
+        let on_connect = self.on_connect.as_ref().map(|f| f(&io));
-            Some(on_connect(&io))
-        } else {
-            None
-        };
 
         Dispatcher::new(io, self.config.clone(), addr, on_connect)
     }

ntex/src/http/h2/service.rs

@@ -260,17 +260,11 @@ where
     fn call(&self, (io, addr): Self::Request) -> Self::Future {
         trace!("New http2 connection, peer address: {:?}", addr);
 
-        let on_connect = if let Some(ref on_connect) = self.on_connect {
-            Some(on_connect(&io))
-        } else {
-            None
-        };
-
         H2ServiceHandlerResponse {
             state: State::Handshake(
                 self.config.clone(),
                 addr,
-                on_connect,
+                self.on_connect.as_ref().map(|f| f(&io)),
                 server::handshake(io),
             ),
         }

ntex/src/http/service.rs

@@ -509,11 +509,7 @@ where
             proto,
             peer_addr
         );
-        let on_connect = if let Some(ref on_connect) = self.on_connect {
+        let on_connect = self.on_connect.as_ref().map(|f| f(&io));
-            Some(on_connect(&io))
-        } else {
-            None
-        };
 
         match proto {
             Protocol::Http2 => HttpServiceHandlerResponse {

ntex/src/server/accept.rs

@@ -331,7 +331,7 @@ impl Accept {
             self.backpressure = true;
             for (_, info) in self.sockets.iter_mut() {
                 // disable err timeout
-                if let None = info.timeout.take() {
+                if info.timeout.take().is_none() {
                     trace!("Enabling backpressure for {}", info.addr);
                     let _ = self.poll.registry().deregister(&mut info.sock);
                 }

ntex/src/util/stream.rs

@@ -72,7 +72,7 @@ where
                     }
                 });
             }
-            if let Poll::Pending = this.service.poll_shutdown(cx, *is_err) {
+            if this.service.poll_shutdown(cx, *is_err).is_pending() {
                 return Poll::Pending;
             }
             return Poll::Ready(());

ntex/src/web/config.rs

@@ -21,7 +21,7 @@ struct AppConfigInner {
 
 impl AppConfig {
     pub(crate) fn new(secure: bool, addr: SocketAddr, host: String) -> Self {
-        AppConfig(Rc::new(AppConfigInner { secure, addr, host }))
+        AppConfig(Rc::new(AppConfigInner { secure, host, addr }))
     }
 
     /// Server host name.

ntex/src/web/httprequest.rs

@@ -41,9 +41,9 @@ impl HttpRequest {
             head,
             path,
             payload,
+            app_data,
             rmap,
             config,
-            app_data,
             pool,
         }))
     }
@@ -218,11 +218,7 @@ impl HttpRequest {
     /// let opt_t = req.app_data::<Data<T>>();
     /// ```
     pub fn app_data<T: 'static>(&self) -> Option<&T> {
-        if let Some(st) = self.0.app_data.get::<T>() {
+        self.0.app_data.get::<T>()
-            Some(&st)
-        } else {
-            None
-        }
     }
 }
 
@@ -322,11 +318,7 @@ impl HttpRequestPool {
     /// Get message from the pool
     #[inline]
     pub(crate) fn get_request(&self) -> Option<HttpRequest> {
-        if let Some(inner) = self.0.borrow_mut().pop() {
+        self.0.borrow_mut().pop().map(HttpRequest)
-            Some(HttpRequest(inner))
-        } else {
-            None
-        }
     }
 
     pub(crate) fn clear(&self) {

ntex/src/web/middleware/compress.rs

@@ -206,13 +206,11 @@ impl AcceptEncoding {
             .collect();
         encodings.sort();
 
-        for enc in encodings {
+        for enc in encodings.into_iter().flatten() {
-            if let Some(enc) = enc {
+            if encoding == ContentEncoding::Auto {
-                if encoding == ContentEncoding::Auto {
+                return enc.encoding;
-                    return enc.encoding;
+            } else if encoding == enc.encoding {
-                } else if encoding == enc.encoding {
+                return encoding;
-                    return encoding;
-                }
             }
         }
         ContentEncoding::Identity

ntex/src/web/test.rs

@@ -759,10 +759,10 @@ where
     };
 
     TestServer {
-        ssl,
         addr,
         client,
         system,
+        ssl,
         server,
     }
 }

ntex/src/web/util.rs

@@ -310,11 +310,7 @@ pub trait BodyEncoding {
 
 impl BodyEncoding for HttpResponseBuilder {
     fn get_encoding(&self) -> Option<ContentEncoding> {
-        if let Some(ref enc) = self.extensions().get::<Enc>() {
+        self.extensions().get::<Enc>().as_ref().map(|enc| enc.0)
-            Some(enc.0)
-        } else {
-            None
-        }
     }
 
     fn encoding(&mut self, encoding: ContentEncoding) -> &mut Self {
@@ -325,11 +321,7 @@ impl BodyEncoding for HttpResponseBuilder {
 
 impl<B> BodyEncoding for HttpResponse<B> {
     fn get_encoding(&self) -> Option<ContentEncoding> {
-        if let Some(ref enc) = self.extensions().get::<Enc>() {
+        self.extensions().get::<Enc>().as_ref().map(|enc| enc.0)
-            Some(enc.0)
-        } else {
-            None
-        }
     }
 
     fn encoding(&mut self, encoding: ContentEncoding) -> &mut Self {