Optimize io driver (#551)

* Update neon api usage

* Refactor polling impl

Cargo.toml

@@ -46,7 +46,12 @@ ntex-compio = { path = "ntex-compio" }
 ntex-tokio = { path = "ntex-tokio" }
 
 [workspace.dependencies]
+ntex-polling = "3.7.4"
+
+async-channel = "2"
 async-task = "4.5.0"
+atomic-waker = "1.1"
+core_affinity = "0.8"
 bitflags = "2"
 cfg_aliases = "0.2.1"
 cfg-if = "1.0.0"
@@ -57,7 +62,8 @@ fxhash = "0.2"
 libc = "0.2.164"
 log = "0.4"
 io-uring = "0.7.4"
-polling = "3.3.0"
+oneshot = "0.1"
+polling = "3.7.4"
 nohash-hasher = "0.2.0"
 scoped-tls = "1.0.1"
 slab = "0.4.9"

ntex-bytes/src/bytes.rs

@@ -965,7 +965,7 @@ impl From<String> for Bytes {
     fn from(src: String) -> Bytes {
         if src.is_empty() {
             Bytes::new()
-        } else if src.bytes().len() <= INLINE_CAP {
+        } else if src.len() <= INLINE_CAP {
             Bytes {
                 inner: Inner::from_slice_inline(src.as_bytes()),
             }

ntex-bytes/tests/test_bytes.rs

@@ -104,6 +104,7 @@ fn clone_mut() {
     assert_eq!(buf1, "hello");
 }
 
+#[allow(clippy::sliced_string_as_bytes)]
 #[test]
 fn fmt_write() {
     use std::fmt::Write;

ntex-io/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-io"
-version = "2.11.1"
+version = "2.11.2"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "Utilities for encoding and decoding frames"
 keywords = ["network", "framework", "async", "futures"]
@@ -28,4 +28,3 @@ pin-project-lite = "0.2"
 [dev-dependencies]
 ntex = "2"
 rand = "0.8"
-env_logger = "0.11"

ntex-io/src/dispatcher.rs

@@ -543,7 +543,7 @@ where
             if self.flags.contains(Flags::KA_ENABLED)
                 && !self.flags.contains(Flags::KA_TIMEOUT)
             {
-                log::debug!(
+                log::trace!(
                     "{}: Start keep-alive timer {:?}",
                     self.shared.io.tag(),
                     self.cfg.keepalive_timeout()

ntex-io/src/io.rs

@@ -98,17 +98,19 @@ impl IoState {
     }
 
     pub(super) fn io_stopped(&self, err: Option<io::Error>) {
-        if err.is_some() {
-            self.error.set(err);
+        if !self.flags.get().contains(Flags::IO_STOPPED) {
+            if err.is_some() {
+                self.error.set(err);
+            }
+            self.read_task.wake();
+            self.write_task.wake();
+            self.dispatch_task.wake();
+            self.notify_disconnect();
+            self.handle.take();
+            self.insert_flags(
+                Flags::IO_STOPPED | Flags::IO_STOPPING | Flags::IO_STOPPING_FILTERS,
+            );
         }
-        self.read_task.wake();
-        self.write_task.wake();
-        self.dispatch_task.wake();
-        self.notify_disconnect();
-        self.handle.take();
-        self.insert_flags(
-            Flags::IO_STOPPED | Flags::IO_STOPPING | Flags::IO_STOPPING_FILTERS,
-        );
     }
 
     /// Gracefully shutdown read and write io tasks
@@ -533,8 +535,8 @@ impl<F> Io<F> {
             } else {
                 match self.poll_read_ready(cx) {
                     Poll::Pending | Poll::Ready(Ok(Some(()))) => {
-                        if log::log_enabled!(log::Level::Debug) && decoded.remains != 0 {
-                            log::debug!(
+                        if log::log_enabled!(log::Level::Trace) && decoded.remains != 0 {
+                            log::trace!(
                                 "{}: Not enough data to decode next frame",
                                 self.tag()
                             );

ntex-io/src/ioref.rs

@@ -246,12 +246,12 @@ impl IoRef {
             if cur_hnd.is_set() {
                 let hnd = timer::update(cur_hnd, timeout, self);
                 if hnd != cur_hnd {
-                    log::debug!("{}: Update timer {:?}", self.tag(), timeout);
+                    log::trace!("{}: Update timer {:?}", self.tag(), timeout);
                     self.0.timeout.set(hnd);
                 }
                 hnd
             } else {
-                log::debug!("{}: Start timer {:?}", self.tag(), timeout);
+                log::trace!("{}: Start timer {:?}", self.tag(), timeout);
                 let hnd = timer::register(timeout, self);
                 self.0.timeout.set(hnd);
                 hnd
@@ -270,7 +270,7 @@ impl IoRef {
     pub fn stop_timer(&self) {
         let hnd = self.0.timeout.get();
         if hnd.is_set() {
-            log::debug!("{}: Stop timer", self.tag());
+            log::trace!("{}: Stop timer", self.tag());
             self.0.timeout.set(timer::TimerHandle::ZERO);
             timer::unregister(hnd, self)
         }

ntex-io/src/tasks.rs

@@ -395,6 +395,12 @@ impl IoContext {
         self.0 .0.io_stopped(e);
     }
 
+    #[inline]
+    /// Check if Io stopped
+    pub fn is_stopped(&self) -> bool {
+        self.0.flags().is_stopped()
+    }
+
     /// Wait when io get closed or preparing for close
     pub async fn shutdown(&self, flush_buf: bool) {
         let st = &self.0 .0;
@@ -668,7 +674,6 @@ impl IoContext {
         // set buffer back
         let result = match result {
             Ok(0) => {
-                // log::debug!("{}: WROTE ALL {:?}", self.0.tag(), inner.buffer.write_destination_size());
                 self.0.memory_pool().release_write_buf(buf);
                 Ok(inner.buffer.write_destination_size())
             }
@@ -678,7 +683,6 @@ impl IoContext {
                     self.0.memory_pool().release_write_buf(b);
                 }
                 let l = buf.len();
-                // log::debug!("{}: WROTE SOME {:?}", self.0.tag(), l);
                 inner.buffer.set_write_destination(buf);
                 Ok(l)
             }
@@ -735,76 +739,31 @@ impl IoContext {
         false
     }
 
-    pub fn is_write_ready(&self) -> bool {
-        if let Some(waker) = self.0 .0.write_task.take() {
-            let ready = self
-                .0
-                .filter()
-                .poll_write_ready(&mut Context::from_waker(&waker));
-            if !matches!(
-                ready,
-                Poll::Ready(WriteStatus::Ready | WriteStatus::Shutdown)
-            ) {
-                return true;
-            }
-        }
-        false
-    }
-
     pub fn with_read_buf<F>(&self, f: F) -> Poll<()>
     where
-        F: FnOnce(&mut BytesVec) -> Poll<io::Result<usize>>,
+        F: FnOnce(&mut BytesVec, usize, usize) -> (usize, Poll<io::Result<()>>),
     {
         let inner = &self.0 .0;
         let (hw, lw) = self.0.memory_pool().read_params().unpack();
-        let result = inner.buffer.with_read_source(&self.0, |buf| {
-            // make sure we've got room
-            let remaining = buf.remaining_mut();
-            if remaining < lw {
-                buf.reserve(hw - remaining);
-            }
-
-            f(buf)
-        });
+        let (nbytes, result) = inner.buffer.with_read_source(&self.0, |buf| f(buf, hw, lw));
 
         // handle buffer changes
-        match result {
-            Poll::Ready(Ok(0)) => {
-                inner.io_stopped(None);
-                Poll::Ready(())
-            }
-            Poll::Ready(Ok(nbytes)) => {
-                let filter = self.0.filter();
-                let _ = filter
-                    .process_read_buf(&self.0, &inner.buffer, 0, nbytes)
-                    .and_then(|status| {
-                        if status.nbytes > 0 {
-                            // dest buffer has new data, wake up dispatcher
-                            if inner.buffer.read_destination_size() >= hw {
-                                log::trace!(
-                                    "{}: Io read buffer is too large {}, enable read back-pressure",
-                                    self.0.tag(),
-                                    nbytes
-                                );
-                                inner.insert_flags(Flags::BUF_R_READY | Flags::BUF_R_FULL);
-                            } else {
-                                inner.insert_flags(Flags::BUF_R_READY);
-
-                                if nbytes >= hw {
-                                    // read task is paused because of read back-pressure
-                                    // but there is no new data in top most read buffer
-                                    // so we need to wake up read task to read more data
-                                    // otherwise read task would sleep forever
-                                    inner.read_task.wake();
-                                }
-                            }
+        let st_res = if nbytes > 0 {
+            let filter = self.0.filter();
+            match filter.process_read_buf(&self.0, &inner.buffer, 0, nbytes) {
+                Ok(status) => {
+                    if status.nbytes > 0 {
+                        // dest buffer has new data, wake up dispatcher
+                        if inner.buffer.read_destination_size() >= hw {
                             log::trace!(
-                                "{}: New {} bytes available, wakeup dispatcher",
+                                "{}: Io read buffer is too large {}, enable read back-pressure",
                                 self.0.tag(),
                                 nbytes
                             );
-                            inner.dispatch_task.wake();
+                            inner.insert_flags(Flags::BUF_R_READY | Flags::BUF_R_FULL);
                         } else {
+                            inner.insert_flags(Flags::BUF_R_READY);
+
                             if nbytes >= hw {
                                 // read task is paused because of read back-pressure
                                 // but there is no new data in top most read buffer
@@ -812,36 +771,70 @@ impl IoContext {
                                 // otherwise read task would sleep forever
                                 inner.read_task.wake();
                             }
-                            if inner.flags.get().is_waiting_for_read() {
-                                // in case of "notify" we must wake up dispatch task
-                                // if we read any data from source
-                                inner.dispatch_task.wake();
-                            }
                         }
-
-                        // while reading, filter wrote some data
-                        // in that case filters need to process write buffers
-                        // and potentialy wake write task
-                        if status.need_write {
-                            filter.process_write_buf(&self.0, &inner.buffer, 0)
-                        } else {
-                            Ok(())
-                        }
-                    })
-                    .map_err(|err| {
+                        log::trace!(
+                            "{}: New {} bytes available, wakeup dispatcher",
+                            self.0.tag(),
+                            nbytes
+                        );
                         inner.dispatch_task.wake();
-                        inner.io_stopped(Some(err));
-                        inner.insert_flags(Flags::BUF_R_READY);
-                    });
-                Poll::Pending
+                    } else {
+                        if nbytes >= hw {
+                            // read task is paused because of read back-pressure
+                            // but there is no new data in top most read buffer
+                            // so we need to wake up read task to read more data
+                            // otherwise read task would sleep forever
+                            inner.read_task.wake();
+                        }
+                        if inner.flags.get().is_waiting_for_read() {
+                            // in case of "notify" we must wake up dispatch task
+                            // if we read any data from source
+                            inner.dispatch_task.wake();
+                        }
+                    }
+
+                    // while reading, filter wrote some data
+                    // in that case filters need to process write buffers
+                    // and potentialy wake write task
+                    if status.need_write {
+                        filter.process_write_buf(&self.0, &inner.buffer, 0)
+                    } else {
+                        Ok(())
+                    }
+                }
+                Err(err) => {
+                    inner.insert_flags(Flags::BUF_R_READY);
+                    Err(err)
+                }
+            }
+        } else {
+            Ok(())
+        };
+
+        match result {
+            Poll::Ready(Ok(_)) => {
+                if let Err(e) = st_res {
+                    inner.io_stopped(Some(e));
+                    Poll::Ready(())
+                } else if nbytes == 0 {
+                    inner.io_stopped(None);
+                    Poll::Ready(())
+                } else {
+                    Poll::Pending
+                }
             }
             Poll::Ready(Err(e)) => {
                 inner.io_stopped(Some(e));
                 Poll::Ready(())
             }
             Poll::Pending => {
-                self.shutdown_filters();
-                Poll::Pending
+                if let Err(e) = st_res {
+                    inner.io_stopped(Some(e));
+                    Poll::Ready(())
+                } else {
+                    self.shutdown_filters();
+                    Poll::Pending
+                }
             }
         }
     }

ntex-macros/Cargo.toml

@@ -18,4 +18,3 @@ proc-macro2 = "^1"
 [dev-dependencies]
 ntex = "2"
 futures = "0.3"
-env_logger = "0.11"

ntex-net/CHANGES.md

@@ -1,5 +1,21 @@
 # Changes
 
+## [2.5.11] - 2025-04-05
+
+* Various improvements for polling driver
+
+## [2.5.10] - 2025-03-28
+
+* Better closed sockets handling
+
+## [2.5.9] - 2025-03-27
+
+* Handle closed sockets
+
+## [2.5.8] - 2025-03-25
+
+* Update neon runtime
+
 ## [2.5.7] - 2025-03-21
 
 * Simplify neon poll impl

ntex-net/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-net"
-version = "2.5.7"
+version = "2.5.11"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "ntexwork utils for ntex framework"
 keywords = ["network", "framework", "async", "futures"]
@@ -27,34 +27,32 @@ compio = ["ntex-rt/compio", "ntex-compio"]
 # neon runtime
 neon = ["ntex-rt/neon", "ntex-neon", "slab", "socket2"]
 
-polling = ["ntex-neon/polling", "dep:polling"]
-io-uring = ["ntex-neon/io-uring", "dep:io-uring"]
+io-uring = ["ntex-neon/io-uring", "dep:io-uring", "socket2"]
 
 [dependencies]
 ntex-service = "3.3"
 ntex-bytes = "0.1"
 ntex-http = "0.1"
-ntex-io = "2.11.1"
-ntex-rt = "0.4.25"
+ntex-io = "2.11.2"
+ntex-rt = "0.4.30"
 ntex-util = "2.5"
 
 ntex-tokio = { version = "0.5.3", optional = true }
 ntex-compio = { version = "0.2.4", optional = true }
-ntex-neon = { version = "0.1.7", optional = true }
+ntex-neon = { version = "0.1.17", optional = true }
 
 bitflags = { workspace = true }
 cfg-if = { workspace = true }
 log = { workspace = true }
 libc = { workspace = true }
 slab = { workspace = true, optional = true }
-socket2 = { workspace = true, optional = true }
+socket2 = { workspace = true, optional = true, features = ["all"] }
 thiserror = { workspace = true }
 
 # Linux specific dependencies
 [target.'cfg(target_os = "linux")'.dependencies]
 io-uring = { workspace = true, optional = true }
-polling = { workspace = true, optional = true }
 
 [dev-dependencies]
 ntex = "2"
-env_logger = "0.11"
+oneshot = "0.1"

ntex-net/src/lib.rs

@@ -14,14 +14,14 @@ cfg_if::cfg_if! {
         mod rt_impl;
         pub use self::rt_impl::{
             from_tcp_stream, from_unix_stream, tcp_connect, tcp_connect_in, unix_connect,
-            unix_connect_in,
+            unix_connect_in, active_stream_ops
         };
     } else if #[cfg(all(unix, feature = "neon"))] {
         #[path = "rt_polling/mod.rs"]
         mod rt_impl;
         pub use self::rt_impl::{
             from_tcp_stream, from_unix_stream, tcp_connect, tcp_connect_in, unix_connect,
-            unix_connect_in,
+            unix_connect_in, active_stream_ops
         };
     } else {
         pub use self::compat::*;

ntex-net/src/rt_polling/connect.rs

@@ -34,7 +34,7 @@ impl ConnectOps {
     pub(crate) fn current() -> Self {
         Runtime::value(|rt| {
             let mut inner = None;
-            rt.driver().register(|api| {
+            rt.register_handler(|api| {
                 let ops = Rc::new(ConnectOpsInner {
                     api,
                     connects: RefCell::new(Slab::new()),
@@ -62,17 +62,16 @@ impl ConnectOps {
         let item = Item { fd, sender };
         let id = self.0.connects.borrow_mut().insert(item);
 
-        self.0.api.attach(fd, id as u32, Some(Event::writable(0)));
+        self.0.api.attach(fd, id as u32, Event::writable(0));
         Ok(id)
     }
 }
 
 impl Handler for ConnectOpsBatcher {
     fn event(&mut self, id: usize, event: Event) {
-        log::debug!("connect-fd is readable {:?}", id);
+        log::trace!("connect-fd is readable {:?}", id);
 
         let mut connects = self.inner.connects.borrow_mut();
-
         if connects.contains(id) {
             let item = connects.remove(id);
             if event.writable {

ntex-net/src/rt_polling/driver.rs

@@ -1,5 +1,5 @@
-use std::os::fd::{AsRawFd, RawFd};
-use std::{cell::Cell, cell::RefCell, future::Future, io, rc::Rc, task, task::Poll};
+use std::os::fd::RawFd;
+use std::{cell::Cell, cell::RefCell, future::Future, io, rc::Rc, task::Poll};
 
 use ntex_neon::driver::{DriverApi, Event, Handler};
 use ntex_neon::{syscall, Runtime};
@@ -8,51 +8,45 @@ use slab::Slab;
 use ntex_bytes::BufMut;
 use ntex_io::IoContext;
 
-pub(crate) struct StreamCtl<T> {
+pub(crate) struct StreamCtl {
     id: u32,
-    inner: Rc<StreamOpsInner<T>>,
+    inner: Rc<StreamOpsInner>,
 }
 
 bitflags::bitflags! {
     #[derive(Copy, Clone, Debug)]
     struct Flags: u8 {
-        const RD = 0b0000_0001;
-        const WR = 0b0000_0010;
+        const RD     = 0b0000_0001;
+        const WR     = 0b0000_0010;
+        const CLOSED = 0b0001_0000;
     }
 }
 
-struct StreamItem<T> {
-    io: Option<T>,
+struct StreamItem {
     fd: RawFd,
     flags: Flags,
     ref_count: u16,
     context: IoContext,
 }
 
-pub(crate) struct StreamOps<T>(Rc<StreamOpsInner<T>>);
+pub(crate) struct StreamOps(Rc<StreamOpsInner>);
 
-struct StreamOpsHandler<T> {
-    inner: Rc<StreamOpsInner<T>>,
+struct StreamOpsHandler {
+    inner: Rc<StreamOpsInner>,
 }
 
-struct StreamOpsInner<T> {
+struct StreamOpsInner {
     api: DriverApi,
     delayd_drop: Cell<bool>,
     feed: RefCell<Vec<u32>>,
-    streams: Cell<Option<Box<Slab<StreamItem<T>>>>>,
+    streams: Cell<Option<Box<Slab<StreamItem>>>>,
 }
 
-impl<T> StreamItem<T> {
-    fn tag(&self) -> &'static str {
-        self.context.tag()
-    }
-}
-
-impl<T: AsRawFd + 'static> StreamOps<T> {
+impl StreamOps {
     pub(crate) fn current() -> Self {
         Runtime::value(|rt| {
             let mut inner = None;
-            rt.driver().register(|api| {
+            rt.register_handler(|api| {
                 let ops = Rc::new(StreamOpsInner {
                     api,
                     feed: RefCell::new(Vec::new()),
@@ -67,13 +61,15 @@ impl<T: AsRawFd + 'static> StreamOps<T> {
         })
     }
 
-    pub(crate) fn register(&self, io: T, context: IoContext) -> StreamCtl<T> {
-        let fd = io.as_raw_fd();
+    pub(crate) fn active_ops() -> usize {
+        Self::current().0.with(|streams| streams.len())
+    }
+
+    pub(crate) fn register(&self, fd: RawFd, context: IoContext) -> StreamCtl {
         let stream = self.0.with(move |streams| {
             let item = StreamItem {
                 fd,
                 context,
-                io: Some(io),
                 ref_count: 1,
                 flags: Flags::empty(),
             };
@@ -83,81 +79,75 @@ impl<T: AsRawFd + 'static> StreamOps<T> {
             }
         });
 
-        self.0.api.attach(
-            fd,
-            stream.id,
-            Some(Event::new(0, false, false).with_interrupt()),
-        );
+        self.0
+            .api
+            .attach(fd, stream.id, Event::new(0, false, false));
         stream
     }
 }
 
-impl<T> Clone for StreamOps<T> {
+impl Clone for StreamOps {
     fn clone(&self) -> Self {
         Self(self.0.clone())
     }
 }
 
-impl<T> Handler for StreamOpsHandler<T> {
+impl Handler for StreamOpsHandler {
     fn event(&mut self, id: usize, ev: Event) {
-        log::debug!("FD event {:?} event: {:?}", id, ev);
-
         self.inner.with(|streams| {
             if !streams.contains(id) {
                 return;
             }
             let item = &mut streams[id];
-
-            // handle HUP
-            if ev.is_interrupt() {
-                item.context.stopped(None);
-                if item.io.take().is_some() {
-                    close(id as u32, item.fd, &self.inner.api);
-                }
+            if item.flags.contains(Flags::CLOSED) {
                 return;
             }
 
-            let mut renew_ev = Event::new(0, false, false).with_interrupt();
+            log::trace!("{}: Event ({:?}): {:?}", item.tag(), item.fd, ev);
 
+            let mut flags = item.flags;
+            let mut renew = Event::new(0, false, false);
             if ev.readable {
-                let res = item.context.with_read_buf(|buf| {
-                    let chunk = buf.chunk_mut();
-                    let result = task::ready!(syscall!(
-                        break libc::read(item.fd, chunk.as_mut_ptr() as _, chunk.len())
-                    ));
-                    if let Ok(size) = result {
-                        log::debug!("{}: data {:?}, s: {:?}", item.tag(), item.fd, size);
-                        unsafe { buf.advance_mut(size) };
-                    }
-                    Poll::Ready(result)
-                });
-
-                if res.is_pending() && item.context.is_read_ready() {
-                    renew_ev.readable = true;
-                    item.flags.insert(Flags::RD);
+                if item
+                    .read(&mut flags, id as u32, &self.inner.api)
+                    .is_pending()
+                    && item.can_read()
+                {
+                    renew.readable = true;
+                    flags.insert(Flags::RD);
                 } else {
-                    item.flags.remove(Flags::RD);
+                    flags.remove(Flags::RD);
                 }
-            } else if item.flags.contains(Flags::RD) {
-                renew_ev.readable = true;
+            } else if flags.contains(Flags::RD) {
+                renew.readable = true;
             }
 
             if ev.writable {
                 let result = item.context.with_write_buf(|buf| {
-                    log::debug!("{}: write {:?} s: {:?}", item.tag(), item.fd, buf.len());
+                    log::trace!("{}: write {:?} s: {:?}", item.tag(), item.fd, buf.len());
                     syscall!(break libc::write(item.fd, buf[..].as_ptr() as _, buf.len()))
                 });
                 if result.is_pending() {
-                    renew_ev.writable = true;
-                    item.flags.insert(Flags::WR);
+                    renew.writable = true;
+                    flags.insert(Flags::WR);
                 } else {
-                    item.flags.remove(Flags::WR);
+                    flags.remove(Flags::WR);
                 }
-            } else if item.flags.contains(Flags::WR) {
-                renew_ev.writable = true;
+            } else if flags.contains(Flags::WR) {
+                renew.writable = true;
+            }
+            item.flags = flags;
+
+            // handle HUP
+            if ev.is_interrupt() {
+                item.close(id as u32, &self.inner.api, None, false);
+                return;
             }
 
-            self.inner.api.modify(item.fd, id as u32, renew_ev);
+            // register Event in driver
+            if !item.flags.contains(Flags::CLOSED) {
+                self.inner.api.modify(item.fd, id as u32, renew);
+            }
 
             // delayed drops
             if self.inner.delayd_drop.get() {
@@ -165,17 +155,14 @@ impl<T> Handler for StreamOpsHandler<T> {
                     let item = &mut streams[id as usize];
                     item.ref_count -= 1;
                     if item.ref_count == 0 {
-                        let item = streams.remove(id as usize);
-                        log::debug!(
-                            "{}: Drop ({}), {:?}, has-io: {}",
+                        let mut item = streams.remove(id as usize);
+                        log::trace!(
+                            "{}: Drop ({:?}), flags: {:?}",
                             item.tag(),
-                            id,
                             item.fd,
-                            item.io.is_some()
+                            item.flags
                         );
-                        if item.io.is_some() {
-                            close(id, item.fd, &self.inner.api);
-                        }
+                        item.close(id, &self.inner.api, None, true);
                     }
                 }
                 self.inner.delayd_drop.set(false);
@@ -186,20 +173,22 @@ impl<T> Handler for StreamOpsHandler<T> {
     fn error(&mut self, id: usize, err: io::Error) {
         self.inner.with(|streams| {
             if let Some(item) = streams.get_mut(id) {
-                log::debug!("FD is failed ({}) {:?}, err: {:?}", id, item.fd, err);
-                item.context.stopped(Some(err));
-                if item.io.take().is_some() {
-                    close(id as u32, item.fd, &self.inner.api);
-                }
+                log::trace!(
+                    "{}: FD is failed ({:?}) err: {:?}",
+                    item.tag(),
+                    item.fd,
+                    err
+                );
+                item.close(id as u32, &self.inner.api, Some(err), false);
             }
         })
     }
 }
 
-impl<T> StreamOpsInner<T> {
+impl StreamOpsInner {
     fn with<F, R>(&self, f: F) -> R
     where
-        F: FnOnce(&mut Slab<StreamItem<T>>) -> R,
+        F: FnOnce(&mut Slab<StreamItem>) -> R,
     {
         let mut streams = self.streams.take().unwrap();
         let result = f(&mut streams);
@@ -208,27 +197,12 @@ impl<T> StreamOpsInner<T> {
     }
 }
 
-fn close(id: u32, fd: RawFd, api: &DriverApi) -> ntex_rt::JoinHandle<io::Result<i32>> {
-    api.detach(fd, id);
-    ntex_rt::spawn_blocking(move || {
-        syscall!(libc::shutdown(fd, libc::SHUT_RDWR))?;
-        syscall!(libc::close(fd))
-    })
-}
-
-impl<T> StreamCtl<T> {
+impl StreamCtl {
     pub(crate) fn close(self) -> impl Future<Output = io::Result<()>> {
         let id = self.id as usize;
-        let (io, fd) = self
+        let fut = self
             .inner
-            .with(|streams| (streams[id].io.take(), streams[id].fd));
-        let fut = if let Some(io) = io {
-            log::debug!("Closing ({}), {:?}", id, fd);
-            std::mem::forget(io);
-            Some(close(self.id, fd, &self.inner.api))
-        } else {
-            None
-        };
+            .with(|streams| streams[id].close(self.id, &self.inner.api, None, true));
         async move {
             if let Some(fut) = fut {
                 fut.await
@@ -239,66 +213,44 @@ impl<T> StreamCtl<T> {
         }
     }
 
-    pub(crate) fn with_io<F, R>(&self, f: F) -> R
-    where
-        F: FnOnce(Option<&T>) -> R,
-    {
-        self.inner
-            .with(|streams| f(streams[self.id as usize].io.as_ref()))
-    }
-
-    pub(crate) fn modify(&self, rd: bool, wr: bool) {
+    pub(crate) fn modify(&self, rd: bool, wr: bool) -> bool {
         self.inner.with(|streams| {
             let item = &mut streams[self.id as usize];
+            if item.flags.contains(Flags::CLOSED) {
+                return false;
+            }
 
-            log::debug!(
-                "{}: Modify interest ({}), {:?} rd: {:?}, wr: {:?}",
+            log::trace!(
+                "{}: Modify interest ({:?}) rd: {:?}, wr: {:?}",
                 item.tag(),
-                self.id,
                 item.fd,
                 rd,
                 wr
             );
 
-            let mut event = Event::new(0, false, false).with_interrupt();
+            let mut flags = item.flags;
+            let mut event = Event::new(0, false, false);
 
             if rd {
-                if item.flags.contains(Flags::RD) {
+                if flags.contains(Flags::RD) {
                     event.readable = true;
-                } else {
-                    let res = item.context.with_read_buf(|buf| {
-                        let chunk = buf.chunk_mut();
-                        let result = task::ready!(syscall!(
-                            break libc::read(item.fd, chunk.as_mut_ptr() as _, chunk.len())
-                        ));
-                        if let Ok(size) = result {
-                            log::debug!(
-                                "{}: read {:?}, s: {:?}",
-                                item.tag(),
-                                item.fd,
-                                size
-                            );
-                            unsafe { buf.advance_mut(size) };
-                        }
-                        Poll::Ready(result)
-                    });
-
-                    if res.is_pending() && item.context.is_read_ready() {
-                        event.readable = true;
-                        item.flags.insert(Flags::RD);
-                    }
+                } else if item.read(&mut flags, self.id, &self.inner.api).is_pending() {
+                    event.readable = true;
+                    flags.insert(Flags::RD);
                 }
+            } else if flags.contains(Flags::RD) {
+                flags.remove(Flags::RD);
             }
 
             if wr {
-                if item.flags.contains(Flags::WR) {
+                if flags.contains(Flags::WR) {
                     event.writable = true;
                 } else {
                     let result = item.context.with_write_buf(|buf| {
-                        log::debug!(
+                        log::trace!(
                             "{}: Writing ({}), buf: {:?}",
                             item.tag(),
-                            self.id,
+                            item.fd,
                             buf.len()
                         );
                         syscall!(
@@ -308,17 +260,25 @@ impl<T> StreamCtl<T> {
 
                     if result.is_pending() {
                         event.writable = true;
-                        item.flags.insert(Flags::WR);
+                        flags.insert(Flags::WR);
                     }
                 }
+            } else if flags.contains(Flags::WR) {
+                flags.remove(Flags::WR);
             }
+            item.flags = flags;
 
-            self.inner.api.modify(item.fd, self.id, event);
+            if !flags.contains(Flags::CLOSED) {
+                self.inner.api.modify(item.fd, self.id, event);
+                true
+            } else {
+                false
+            }
         })
     }
 }
 
-impl<T> Clone for StreamCtl<T> {
+impl Clone for StreamCtl {
     fn clone(&self) -> Self {
         self.inner.with(|streams| {
             streams[self.id as usize].ref_count += 1;
@@ -330,23 +290,20 @@ impl<T> Clone for StreamCtl<T> {
     }
 }
 
-impl<T> Drop for StreamCtl<T> {
+impl Drop for StreamCtl {
     fn drop(&mut self) {
         if let Some(mut streams) = self.inner.streams.take() {
             let id = self.id as usize;
             streams[id].ref_count -= 1;
             if streams[id].ref_count == 0 {
-                let item = streams.remove(id);
-                log::debug!(
-                    "{}:  Drop io ({}), {:?}, has-io: {}",
+                let mut item = streams.remove(id);
+                log::trace!(
+                    "{}: Drop io ({:?}), flags: {:?}",
                     item.tag(),
-                    self.id,
                     item.fd,
-                    item.io.is_some()
+                    item.flags
                 );
-                if item.io.is_some() {
-                    close(self.id, item.fd, &self.inner.api);
-                }
+                item.close(self.id, &self.inner.api, None, true);
             }
             self.inner.streams.set(Some(streams));
         } else {
@@ -355,3 +312,103 @@ impl<T> Drop for StreamCtl<T> {
         }
     }
 }
+
+impl StreamItem {
+    fn tag(&self) -> &'static str {
+        self.context.tag()
+    }
+
+    fn can_read(&self) -> bool {
+        self.context.is_read_ready()
+    }
+
+    fn read(&mut self, flags: &mut Flags, id: u32, api: &DriverApi) -> Poll<()> {
+        let mut close = false;
+
+        let result = self.context.with_read_buf(|buf, hw, lw| {
+            let mut total = 0;
+            loop {
+                // make sure we've got room
+                if buf.remaining_mut() < lw {
+                    buf.reserve(hw);
+                }
+
+                let chunk = buf.chunk_mut();
+                let chunk_len = chunk.len();
+                let chunk_ptr = chunk.as_mut_ptr();
+
+                let res = syscall!(break libc::read(self.fd, chunk_ptr as _, chunk_len));
+                if let Poll::Ready(Ok(size)) = res {
+                    unsafe { buf.advance_mut(size) };
+                    total += size;
+                    if size == chunk_len {
+                        continue;
+                    }
+                }
+
+                log::trace!(
+                    "{}: Read fd ({:?}), size: {:?}, cap: {:?}, result: {:?}",
+                    self.tag(),
+                    self.fd,
+                    total,
+                    buf.remaining_mut(),
+                    res
+                );
+
+                return match res {
+                    Poll::Ready(Err(err)) => {
+                        close = true;
+                        (total, Poll::Ready(Err(err)))
+                    }
+                    Poll::Ready(Ok(size)) => {
+                        if size == 0 {
+                            close = true;
+                        }
+                        (total, Poll::Ready(Ok(())))
+                    }
+                    Poll::Pending => (total, Poll::Pending),
+                };
+            }
+        });
+
+        if close {
+            flags.insert(Flags::CLOSED);
+            self.close(id, api, None, false);
+        }
+        result
+    }
+
+    fn close(
+        &mut self,
+        id: u32,
+        api: &DriverApi,
+        error: Option<io::Error>,
+        shutdown: bool,
+    ) -> Option<ntex_rt::JoinHandle<io::Result<i32>>> {
+        if !self.flags.contains(Flags::CLOSED) {
+            log::trace!(
+                "{}: Closing ({}) sh: {:?}, flags: {:?}, ctx: {:?}",
+                self.tag(),
+                self.fd,
+                shutdown,
+                self.flags,
+                self.context.flags()
+            );
+            self.flags.insert(Flags::CLOSED);
+            if !self.context.is_stopped() {
+                self.context.stopped(error);
+            }
+
+            let fd = self.fd;
+            api.detach(fd, id);
+            Some(ntex_rt::spawn_blocking(move || {
+                if shutdown {
+                    let _ = syscall!(libc::shutdown(fd, libc::SHUT_RDWR));
+                }
+                syscall!(libc::close(fd))
+            }))
+        } else {
+            None
+        }
+    }
+}

ntex-net/src/rt_polling/io.rs

@@ -1,4 +1,4 @@
-use std::{any, future::poll_fn, task::Poll};
+use std::{any, future::poll_fn, mem, os::fd::AsRawFd, task::Poll};
 
 use ntex_io::{
     types, Handle, IoContext, IoStream, ReadContext, ReadStatus, WriteContext, WriteStatus,
@@ -12,11 +12,10 @@ impl IoStream for super::TcpStream {
     fn start(self, read: ReadContext, _: WriteContext) -> Option<Box<dyn Handle>> {
         let io = self.0;
         let context = read.context();
-        let ctl = StreamOps::current().register(io, context.clone());
-        let ctl2 = ctl.clone();
+        let ctl = StreamOps::current().register(io.as_raw_fd(), context.clone());
         spawn(async move { run(ctl, context).await });
 
-        Some(Box::new(HandleWrapper(ctl2)))
+        Some(Box::new(HandleWrapper(Some(io))))
     }
 }
 
@@ -24,19 +23,20 @@ impl IoStream for super::UnixStream {
     fn start(self, read: ReadContext, _: WriteContext) -> Option<Box<dyn Handle>> {
         let io = self.0;
         let context = read.context();
-        let ctl = StreamOps::current().register(io, context.clone());
+        let ctl = StreamOps::current().register(io.as_raw_fd(), context.clone());
         spawn(async move { run(ctl, context).await });
+        mem::forget(io);
 
         None
     }
 }
 
-struct HandleWrapper(StreamCtl<Socket>);
+struct HandleWrapper(Option<Socket>);
 
 impl Handle for HandleWrapper {
     fn query(&self, id: any::TypeId) -> Option<Box<dyn any::Any>> {
         if id == any::TypeId::of::<types::PeerAddr>() {
-            let addr = self.0.with_io(|io| io.and_then(|io| io.peer_addr().ok()));
+            let addr = self.0.as_ref().unwrap().peer_addr().ok();
             if let Some(addr) = addr.and_then(|addr| addr.as_socket()) {
                 return Some(Box::new(types::PeerAddr(addr)));
             }
@@ -45,13 +45,19 @@ impl Handle for HandleWrapper {
     }
 }
 
+impl Drop for HandleWrapper {
+    fn drop(&mut self) {
+        mem::forget(self.0.take());
+    }
+}
+
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 enum Status {
     Shutdown,
     Terminate,
 }
 
-async fn run<T>(ctl: StreamCtl<T>, context: IoContext) {
+async fn run(ctl: StreamCtl, context: IoContext) {
     // Handle io read readiness
     let st = poll_fn(|cx| {
         let mut modify = false;
@@ -81,8 +87,8 @@ async fn run<T>(ctl: StreamCtl<T>, context: IoContext) {
             Poll::Pending => Poll::Pending,
         };
 
-        if modify {
-            ctl.modify(readable, writable);
+        if modify && !ctl.modify(readable, writable) {
+            return Poll::Ready(Status::Terminate);
         }
 
         if read.is_pending() && write.is_pending() {
@@ -95,7 +101,10 @@ async fn run<T>(ctl: StreamCtl<T>, context: IoContext) {
     })
     .await;
 
-    ctl.modify(false, true);
-    context.shutdown(st == Status::Shutdown).await;
-    context.stopped(ctl.close().await.err());
+    if st != Status::Terminate && ctl.modify(false, true) {
+        context.shutdown(st == Status::Shutdown).await;
+    }
+    if !context.is_stopped() {
+        context.stopped(ctl.close().await.err());
+    }
 }

ntex-net/src/rt_polling/mod.rs

@@ -67,3 +67,68 @@ pub fn from_unix_stream(stream: std::os::unix::net::UnixStream) -> Result<Io> {
         Socket::from(stream),
     )?)))
 }
+
+#[doc(hidden)]
+/// Get number of active Io objects
+pub fn active_stream_ops() -> usize {
+    self::driver::StreamOps::active_ops()
+}
+
+#[cfg(all(target_os = "linux", feature = "neon"))]
+#[cfg(test)]
+mod tests {
+    use ntex::{io::Io, time::sleep, time::Millis, util::PoolId};
+    use std::sync::{Arc, Mutex};
+
+    use crate::connect::Connect;
+
+    const DATA: &[u8] = b"Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World \
+                         Hello World Hello World Hello World Hello World Hello World";
+
+    // #[ntex::test]
+    async fn idle_disconnect() {
+        PoolId::P5.set_read_params(24, 12);
+        let (tx, rx) = ::oneshot::channel();
+        let tx = Arc::new(Mutex::new(Some(tx)));
+
+        let server = ntex::server::test_server(move || {
+            let tx = tx.clone();
+            ntex_service::fn_service(move |io: Io<_>| {
+                tx.lock().unwrap().take().unwrap().send(()).unwrap();
+
+                async move {
+                    io.write(DATA).unwrap();
+                    sleep(Millis(250)).await;
+                    io.close();
+                    Ok::<_, ()>(())
+                }
+            })
+        });
+
+        let msg = Connect::new(server.addr());
+        let io = crate::connect::connect(msg).await.unwrap();
+        io.set_memory_pool(PoolId::P5.into());
+        rx.await.unwrap();
+
+        io.on_disconnect().await;
+    }
+}

ntex-net/src/rt_uring/connect.rs

@@ -31,7 +31,7 @@ impl ConnectOps {
     pub(crate) fn current() -> Self {
         Runtime::value(|rt| {
             let mut inner = None;
-            rt.driver().register(|api| {
+            rt.register_handler(|api| {
                 if !api.is_supported(opcode::Connect::CODE) {
                     panic!("opcode::Connect is required for io-uring support");
                 }
@@ -72,14 +72,14 @@ impl ConnectOps {
 
 impl Handler for ConnectOpsHandler {
     fn canceled(&mut self, user_data: usize) {
-        log::debug!("connect-op is canceled {:?}", user_data);
+        log::trace!("connect-op is canceled {:?}", user_data);
 
         self.inner.ops.borrow_mut().remove(user_data);
     }
 
     fn completed(&mut self, user_data: usize, flags: u32, result: io::Result<i32>) {
         let (addr, tx) = self.inner.ops.borrow_mut().remove(user_data);
-        log::debug!(
+        log::trace!(
             "connect-op is completed {:?} result: {:?}, addr: {:?}",
             user_data,
             result,

ntex-net/src/rt_uring/driver.rs

@@ -33,6 +33,12 @@ struct StreamItem<T> {
     wr_op: Option<NonZeroU32>,
 }
 
+impl<T> StreamItem<T> {
+    fn tag(&self) -> &'static str {
+        self.context.tag()
+    }
+}
+
 enum Operation {
     Recv {
         id: usize,
@@ -71,7 +77,7 @@ impl<T: os::fd::AsRawFd + 'static> StreamOps<T> {
     pub(crate) fn current() -> Self {
         Runtime::value(|rt| {
             let mut inner = None;
-            rt.driver().register(|api| {
+            rt.register_handler(|api| {
                 if !api.is_supported(opcode::Recv::CODE) {
                     panic!("opcode::Recv is required for io-uring support");
                 }
@@ -118,6 +124,10 @@ impl<T: os::fd::AsRawFd + 'static> StreamOps<T> {
         }
     }
 
+    pub(crate) fn active_ops() -> usize {
+        Self::current().with(|st| st.streams.len())
+    }
+
     fn with<F, R>(&self, f: F) -> R
     where
         F: FnOnce(&mut StreamOpsStorage<T>) -> R,
@@ -138,7 +148,7 @@ impl<T> Handler for StreamOpsHandler<T> {
 
         match storage.ops.remove(user_data) {
             Operation::Recv { id, buf, context } => {
-                log::debug!("{}: Recv canceled {:?}", context.tag(), id);
+                log::trace!("{}: Recv canceled {:?}", context.tag(), id);
                 context.release_read_buf(buf);
                 if let Some(item) = storage.streams.get_mut(id) {
                     item.rd_op.take();
@@ -154,7 +164,7 @@ impl<T> Handler for StreamOpsHandler<T> {
                 }
             }
             Operation::Send { id, buf, context } => {
-                log::debug!("{}: Send canceled: {:?}", context.tag(), id);
+                log::trace!("{}: Send canceled: {:?}", context.tag(), id);
                 context.release_write_buf(buf);
                 if let Some(item) = storage.streams.get_mut(id) {
                     item.wr_op.take();
@@ -190,7 +200,7 @@ impl<T> Handler for StreamOpsHandler<T> {
 
                 // reset op reference
                 if let Some(item) = storage.streams.get_mut(id) {
-                    log::debug!(
+                    log::trace!(
                         "{}: Recv completed {:?}, res: {:?}, buf({})",
                         context.tag(),
                         item.fd,
@@ -207,13 +217,13 @@ impl<T> Handler for StreamOpsHandler<T> {
                         self.inner.api.submit(id, op);
                     }
                 } else {
-                    log::debug!("{}: Recv to pause", tag);
+                    log::trace!("{}: Recv to pause", tag);
                 }
             }
             Operation::Send { id, buf, context } => {
                 // reset op reference
                 let fd = if let Some(item) = storage.streams.get_mut(id) {
-                    log::debug!(
+                    log::trace!(
                         "{}: Send completed: {:?}, res: {:?}, buf({})",
                         context.tag(),
                         item.fd,
@@ -229,7 +239,7 @@ impl<T> Handler for StreamOpsHandler<T> {
                 // set read buf
                 let result = context.set_write_buf(result.map(|size| size as usize), buf);
                 if result.is_pending() {
-                    log::debug!("{}: Need to send more: {:?}", context.tag(), fd);
+                    log::trace!("{}: Need to send more: {:?}", context.tag(), fd);
                     if let Some((id, op)) = storage.send(id, Some(context)) {
                         self.inner.api.submit(id, op);
                     }
@@ -249,7 +259,7 @@ impl<T> Handler for StreamOpsHandler<T> {
             if storage.streams[id].ref_count == 0 {
                 let mut item = storage.streams.remove(id);
 
-                log::debug!("{}: Drop io ({}), {:?}", item.context.tag(), id, item.fd);
+                log::trace!("{}: Drop io ({}), {:?}", item.tag(), id, item.fd);
 
                 if let Some(io) = item.io.take() {
                     mem::forget(io);
@@ -271,9 +281,9 @@ impl<T> StreamOpsStorage<T> {
 
         if item.rd_op.is_none() {
             if let Poll::Ready(mut buf) = item.context.get_read_buf() {
-                log::debug!(
+                log::trace!(
                     "{}: Recv resume ({}), {:?} rem: {:?}",
-                    item.context.tag(),
+                    item.tag(),
                     id,
                     item.fd,
                     buf.remaining_mut()
@@ -304,9 +314,9 @@ impl<T> StreamOpsStorage<T> {
 
         if item.wr_op.is_none() {
             if let Poll::Ready(buf) = item.context.get_write_buf() {
-                log::debug!(
+                log::trace!(
                     "{}: Send resume ({}), {:?} len: {:?}",
-                    item.context.tag(),
+                    item.tag(),
                     id,
                     item.fd,
                     buf.len()
@@ -396,12 +406,7 @@ impl<T> StreamCtl<T> {
 
         if let Some(rd_op) = item.rd_op {
             if !item.flags.contains(Flags::RD_CANCELING) {
-                log::debug!(
-                    "{}: Recv to pause ({}), {:?}",
-                    item.context.tag(),
-                    self.id,
-                    item.fd
-                );
+                log::trace!("{}: Recv to pause ({}), {:?}", item.tag(), self.id, item.fd);
                 item.flags.insert(Flags::RD_CANCELING);
                 self.inner.api.cancel(rd_op.get());
             }
@@ -426,12 +431,7 @@ impl<T> Drop for StreamCtl<T> {
             if storage.streams[self.id].ref_count == 0 {
                 let mut item = storage.streams.remove(self.id);
                 if let Some(io) = item.io.take() {
-                    log::debug!(
-                        "{}: Close io ({}), {:?}",
-                        item.context.tag(),
-                        self.id,
-                        item.fd
-                    );
+                    log::trace!("{}: Close io ({}), {:?}", item.tag(), self.id, item.fd);
                     mem::forget(io);
 
                     let id = storage.ops.insert(Operation::Close { tx: None });

ntex-net/src/rt_uring/mod.rs

@@ -64,3 +64,9 @@ pub fn from_unix_stream(stream: std::os::unix::net::UnixStream) -> Result<Io> {
         Socket::from(stream),
     )?)))
 }
+
+#[doc(hidden)]
+/// Get number of active Io objects
+pub fn active_stream_ops() -> usize {
+    self::driver::StreamOps::<socket2::Socket>::active_ops()
+}

ntex-rt/CHANGES.md

@@ -1,5 +1,9 @@
 # Changes
 
+## [0.4.29] - 2025-03-26
+
+* Add Arbiter::get_value() helper method
+
 ## [0.4.27] - 2025-03-14
 
 * Add srbiters pings ttl

ntex-rt/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-rt"
-version = "0.4.28"
+version = "0.4.30"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "ntex runtime"
 keywords = ["network", "framework", "async", "futures"]
@@ -32,8 +32,8 @@ neon = ["ntex-neon"]
 [dependencies]
 async-channel = "2"
 futures-timer = "3.0"
-log = "0.4"
 oneshot = "0.1"
+log = "0.4"
 
 compio-driver = { version = "0.6", optional = true }
 compio-runtime = { version = "0.6", optional = true }
@@ -42,7 +42,4 @@ tok-io = { version = "1", package = "tokio", default-features = false, features
     "net",
 ], optional = true }
 
-ntex-neon = { version = "0.1.1", optional = true }
-
-[dev-dependencies]
-env_logger = "0.11"
+ntex-neon = { version = "0.1.17", optional = true }

ntex-rt/src/arbiter.rs

@@ -286,6 +286,25 @@ impl Arbiter {
         })
     }
 
+    /// Get a type previously inserted to this runtime or create new one.
+    pub fn get_value<T, F>(f: F) -> T
+    where
+        T: Clone + 'static,
+        F: FnOnce() -> T,
+    {
+        STORAGE.with(move |cell| {
+            let mut st = cell.borrow_mut();
+            if let Some(boxed) = st.get(&TypeId::of::<T>()) {
+                if let Some(val) = (&**boxed as &(dyn Any + 'static)).downcast_ref::<T>() {
+                    return val.clone();
+                }
+            }
+            let val = f();
+            st.insert(TypeId::of::<T>(), Box::new(val.clone()));
+            val
+        })
+    }
+
     /// Wait for the event loop to stop by joining the underlying thread (if have Some).
     pub fn join(&mut self) -> thread::Result<()> {
         if let Some(thread_handle) = self.thread_handle.take() {
@@ -355,6 +374,7 @@ mod tests {
         assert!(Arbiter::get_item::<&'static str, _, _>(|s| *s == "test"));
         assert!(Arbiter::get_mut_item::<&'static str, _, _>(|s| *s == "test"));
         assert!(Arbiter::contains_item::<&'static str>());
+        assert!(Arbiter::get_value(|| 64u64) == 64);
         assert!(format!("{:?}", Arbiter::current()).contains("Arbiter"));
     }
 }

ntex-rt/src/lib.rs

@@ -112,6 +112,8 @@ mod tokio {
     ///
     /// This function panics if ntex system is not running.
     #[inline]
+    #[doc(hidden)]
+    #[deprecated]
     pub fn spawn_fn<F, R>(f: F) -> tok_io::task::JoinHandle<R::Output>
     where
         F: FnOnce() -> R + 'static,
@@ -196,6 +198,8 @@ mod compio {
     ///
     /// This function panics if ntex system is not running.
     #[inline]
+    #[doc(hidden)]
+    #[deprecated]
     pub fn spawn_fn<F, R>(f: F) -> JoinHandle<R::Output>
     where
         F: FnOnce() -> R + 'static,
@@ -261,7 +265,7 @@ mod neon {
         let rt = Runtime::new().unwrap();
         log::info!(
             "Starting neon runtime, driver {:?}",
-            rt.driver().tp().name()
+            rt.driver_type().name()
         );
 
         rt.block_on(fut);
@@ -323,6 +327,8 @@ mod neon {
     ///
     /// This function panics if ntex system is not running.
     #[inline]
+    #[doc(hidden)]
+    #[deprecated]
     pub fn spawn_fn<F, R>(f: F) -> Task<R::Output>
     where
         F: FnOnce() -> R + 'static,
@@ -377,7 +383,7 @@ mod neon {
 
     impl<T> JoinHandle<T> {
         pub fn is_finished(&self) -> bool {
-            false
+            self.fut.is_none()
         }
     }
 

ntex-server/CHANGES.md

@@ -1,5 +1,13 @@
 # Changes
 
+## [2.7.3] - 2025-03-28
+
+* Better worker availability handling
+
+## [2.7.2] - 2025-03-27
+
+* Handle paused state
+
 ## [2.7.1] - 2025-02-28
 
 * Fix set core affinity out of worker start #508

ntex-server/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex-server"
-version = "2.7.1"
+version = "2.7.4"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "Server for ntex framework"
 keywords = ["network", "framework", "async", "futures"]
@@ -22,13 +22,13 @@ ntex-service = "3.4"
 ntex-rt = "0.4"
 ntex-util = "2.8"
 
-async-channel = "2"
-async-broadcast = "0.7"
-core_affinity = "0.8"
-polling = "3.3"
-log = "0.4"
-socket2 = "0.5"
-oneshot = { version = "0.1", default-features = false, features = ["async"] }
+async-channel = { workspace = true }
+atomic-waker = { workspace = true }
+core_affinity = { workspace = true }
+oneshot = { workspace = true }
+polling = { workspace = true }
+log = { workspace = true }
+socket2 = { workspace = true }
 
 [dev-dependencies]
 ntex = "2"

ntex-server/src/manager.rs

@@ -139,7 +139,6 @@ impl<F: ServerConfiguration> ServerManager<F> {
 fn start_worker<F: ServerConfiguration>(mgr: ServerManager<F>, cid: Option<CoreId>) {
     let _ = ntex_rt::spawn(async move {
         let id = mgr.next_id();
-
         let mut wrk = Worker::start(id, mgr.factory(), cid);
 
         loop {
@@ -181,7 +180,7 @@ impl<F: ServerConfiguration> HandleCmdState<F> {
     fn process(&mut self, mut item: F::Item) {
         loop {
             if !self.workers.is_empty() {
-                if self.next > self.workers.len() {
+                if self.next >= self.workers.len() {
                     self.next = self.workers.len() - 1;
                 }
                 match self.workers[self.next].send(item) {
@@ -212,10 +211,9 @@ impl<F: ServerConfiguration> HandleCmdState<F> {
         match upd {
             Update::Available(worker) => {
                 self.workers.push(worker);
+                self.workers.sort();
                 if self.workers.len() == 1 {
                     self.mgr.resume();
-                } else {
-                    self.workers.sort();
                 }
             }
             Update::Unavailable(worker) => {
@@ -234,6 +232,9 @@ impl<F: ServerConfiguration> HandleCmdState<F> {
                 if let Err(item) = self.workers[0].send(item) {
                     self.backlog.push_back(item);
                     self.workers.remove(0);
+                    if self.workers.is_empty() {
+                        self.mgr.pause();
+                    }
                     break;
                 }
             }

ntex-server/src/net/accept.rs

@@ -92,12 +92,14 @@ impl AcceptLoop {
 
     /// Start accept loop
     pub fn start(mut self, socks: Vec<(Token, Listener)>, srv: Server) {
+        let (tx, rx_start) = oneshot::channel();
         let (rx, poll) = self
             .inner
             .take()
             .expect("AcceptLoop cannot be used multiple times");
 
         Accept::start(
+            tx,
             rx,
             poll,
             socks,
@@ -105,6 +107,8 @@ impl AcceptLoop {
             self.notify.clone(),
             self.status_handler.take(),
         );
+
+        let _ = rx_start.recv();
     }
 }
 
@@ -121,6 +125,7 @@ impl fmt::Debug for AcceptLoop {
 struct Accept {
     poller: Arc<Poller>,
     rx: mpsc::Receiver<AcceptorCommand>,
+    tx: Option<oneshot::Sender<()>>,
     sockets: Vec<ServerSocketInfo>,
     srv: Server,
     notify: AcceptNotify,
@@ -131,6 +136,7 @@ struct Accept {
 
 impl Accept {
     fn start(
+        tx: oneshot::Sender<()>,
         rx: mpsc::Receiver<AcceptorCommand>,
         poller: Arc<Poller>,
         socks: Vec<(Token, Listener)>,
@@ -145,11 +151,12 @@ impl Accept {
             .name("ntex-server accept loop".to_owned())
             .spawn(move || {
                 System::set_current(sys);
-                Accept::new(rx, poller, socks, srv, notify, status_handler).poll()
+                Accept::new(tx, rx, poller, socks, srv, notify, status_handler).poll()
             });
     }
 
     fn new(
+        tx: oneshot::Sender<()>,
         rx: mpsc::Receiver<AcceptorCommand>,
         poller: Arc<Poller>,
         socks: Vec<(Token, Listener)>,
@@ -175,6 +182,7 @@ impl Accept {
             notify,
             srv,
             status_handler,
+            tx: Some(tx),
             backpressure: true,
             backlog: VecDeque::new(),
         }
@@ -192,19 +200,23 @@ impl Accept {
         // Create storage for events
         let mut events = Events::with_capacity(NonZeroUsize::new(512).unwrap());
 
+        let mut timeout = Some(Duration::ZERO);
         loop {
-            if let Err(e) = self.poller.wait(&mut events, None) {
-                if e.kind() == io::ErrorKind::Interrupted {
-                    continue;
-                } else {
+            if let Err(e) = self.poller.wait(&mut events, timeout) {
+                if e.kind() != io::ErrorKind::Interrupted {
                     panic!("Cannot wait for events in poller: {}", e)
                 }
+            } else if timeout.is_some() {
+                timeout = None;
+                let _ = self.tx.take().unwrap().send(());
             }
 
-            for event in events.iter() {
-                let readd = self.accept(event.key);
-                if readd {
-                    self.add_source(event.key);
+            for idx in 0..self.sockets.len() {
+                if self.sockets[idx].registered.get() {
+                    let readd = self.accept(idx);
+                    if readd {
+                        self.add_source(idx);
+                    }
                 }
             }
 

ntex-server/src/net/service.rs

@@ -114,7 +114,7 @@ impl ServiceFactory<Connection> for StreamService {
         for info in &self.services {
             match info.factory.create(()).await {
                 Ok(svc) => {
-                    log::debug!("Constructed server service for {:?}", info.tokens);
+                    log::trace!("Constructed server service for {:?}", info.tokens);
                     services.push(svc);
                     let idx = services.len() - 1;
                     for (token, tag) in &info.tokens {

ntex-server/src/wrk.rs

@@ -2,8 +2,8 @@ use std::sync::atomic::{AtomicBool, Ordering};
 use std::task::{ready, Context, Poll};
 use std::{cmp, future::poll_fn, future::Future, hash, pin::Pin, sync::Arc};
 
-use async_broadcast::{self as bus, broadcast};
 use async_channel::{unbounded, Receiver, Sender};
+use atomic_waker::AtomicWaker;
 use core_affinity::CoreId;
 
 use ntex_rt::{spawn, Arbiter};
@@ -99,10 +99,10 @@ impl<T> Worker<T> {
 
                 log::debug!("Creating server instance in {:?}", id);
                 let factory = cfg.create().await;
-                log::debug!("Server instance has been created in {:?}", id);
 
                 match create(id, rx1, rx2, factory, avail_tx).await {
                     Ok((svc, wrk)) => {
+                        log::debug!("Server instance has been created in {:?}", id);
                         run_worker(svc, wrk).await;
                     }
                     Err(e) => {
@@ -151,10 +151,8 @@ impl<T> Worker<T> {
         if self.failed.load(Ordering::Acquire) {
             WorkerStatus::Failed
         } else {
-            // cleanup updates
-            while self.avail.notify.try_recv().is_ok() {}
-
-            if self.avail.notify.recv_direct().await.is_err() {
+            self.avail.wait_for_update().await;
+            if self.avail.failed() {
                 self.failed.store(true, Ordering::Release);
             }
             self.status()
@@ -196,52 +194,85 @@ impl Future for WorkerStop {
 
 #[derive(Debug, Clone)]
 struct WorkerAvailability {
-    notify: bus::Receiver<()>,
-    available: Arc<AtomicBool>,
+    inner: Arc<Inner>,
 }
 
 #[derive(Debug, Clone)]
 struct WorkerAvailabilityTx {
-    notify: bus::Sender<()>,
-    available: Arc<AtomicBool>,
+    inner: Arc<Inner>,
+}
+
+#[derive(Debug)]
+struct Inner {
+    waker: AtomicWaker,
+    updated: AtomicBool,
+    available: AtomicBool,
+    failed: AtomicBool,
 }
 
 impl WorkerAvailability {
     fn create() -> (Self, WorkerAvailabilityTx) {
-        let (mut tx, rx) = broadcast(16);
-        tx.set_overflow(true);
+        let inner = Arc::new(Inner {
+            waker: AtomicWaker::new(),
+            updated: AtomicBool::new(false),
+            available: AtomicBool::new(false),
+            failed: AtomicBool::new(false),
+        });
 
         let avail = WorkerAvailability {
-            notify: rx,
-            available: Arc::new(AtomicBool::new(false)),
-        };
-        let avail_tx = WorkerAvailabilityTx {
-            notify: tx,
-            available: avail.available.clone(),
+            inner: inner.clone(),
         };
+        let avail_tx = WorkerAvailabilityTx { inner };
         (avail, avail_tx)
     }
 
+    fn failed(&self) -> bool {
+        self.inner.failed.load(Ordering::Acquire)
+    }
+
     fn available(&self) -> bool {
-        self.available.load(Ordering::Acquire)
+        self.inner.available.load(Ordering::Acquire)
+    }
+
+    async fn wait_for_update(&self) {
+        poll_fn(|cx| {
+            if self.inner.updated.load(Ordering::Acquire) {
+                self.inner.updated.store(false, Ordering::Release);
+                Poll::Ready(())
+            } else {
+                self.inner.waker.register(cx.waker());
+                Poll::Pending
+            }
+        })
+        .await;
     }
 }
 
 impl WorkerAvailabilityTx {
     fn set(&self, val: bool) {
-        let old = self.available.swap(val, Ordering::Release);
-        if !old && val {
-            let _ = self.notify.try_broadcast(());
+        let old = self.inner.available.swap(val, Ordering::Release);
+        if old != val {
+            self.inner.updated.store(true, Ordering::Release);
+            self.inner.waker.wake();
         }
     }
 }
 
+impl Drop for WorkerAvailabilityTx {
+    fn drop(&mut self) {
+        self.inner.failed.store(true, Ordering::Release);
+        self.inner.updated.store(true, Ordering::Release);
+        self.inner.available.store(false, Ordering::Release);
+        self.inner.waker.wake();
+    }
+}
+
 /// Service worker
 ///
 /// Worker accepts message via unbounded channel and starts processing.
 struct WorkerSt<T, F: ServiceFactory<T>> {
     id: WorkerId,
-    rx: Pin<Box<dyn Stream<Item = T>>>,
+    rx: Receiver<T>,
     stop: Pin<Box<dyn Stream<Item = Shutdown>>>,
     factory: F,
     availability: WorkerAvailabilityTx,
@@ -253,25 +284,43 @@ where
     F: ServiceFactory<T> + 'static,
 {
     loop {
+        let mut recv = std::pin::pin!(wrk.rx.recv());
         let fut = poll_fn(|cx| {
-            ready!(svc.poll_ready(cx)?);
-
-            if let Some(item) = ready!(Pin::new(&mut wrk.rx).poll_next(cx)) {
-                let fut = svc.call(item);
-                let _ = spawn(async move {
-                    let _ = fut.await;
-                });
+            match svc.poll_ready(cx) {
+                Poll::Ready(Ok(())) => {
+                    wrk.availability.set(true);
+                }
+                Poll::Ready(Err(err)) => {
+                    wrk.availability.set(false);
+                    return Poll::Ready(Err(err));
+                }
+                Poll::Pending => {
+                    wrk.availability.set(false);
+                    return Poll::Pending;
+                }
+            }
+
+            match ready!(recv.as_mut().poll(cx)) {
+                Ok(item) => {
+                    let fut = svc.call(item);
+                    let _ = spawn(async move {
+                        let _ = fut.await;
+                    });
+                    Poll::Ready(Ok::<_, F::Error>(true))
+                }
+                Err(_) => {
+                    log::error!("Server is gone");
+                    Poll::Ready(Ok(false))
+                }
             }
-            Poll::Ready(Ok::<(), F::Error>(()))
         });
 
         match select(fut, stream_recv(&mut wrk.stop)).await {
-            Either::Left(Ok(())) => continue,
+            Either::Left(Ok(true)) => continue,
             Either::Left(Err(_)) => {
                 let _ = ntex_rt::spawn(async move {
                     svc.shutdown().await;
                 });
-                wrk.availability.set(false);
             }
             Either::Right(Some(Shutdown { timeout, result })) => {
                 wrk.availability.set(false);
@@ -285,7 +334,8 @@ where
                 stop_svc(wrk.id, svc, timeout, Some(result)).await;
                 return;
             }
-            Either::Right(None) => {
+            Either::Left(Ok(false)) | Either::Right(None) => {
+                wrk.availability.set(false);
                 stop_svc(wrk.id, svc, STOP_TIMEOUT, None).await;
                 return;
             }
@@ -295,7 +345,6 @@ where
         loop {
             match select(wrk.factory.create(()), stream_recv(&mut wrk.stop)).await {
                 Either::Left(Ok(service)) => {
-                    wrk.availability.set(true);
                     svc = Pipeline::new(service).bind();
                     break;
                 }
@@ -336,8 +385,6 @@ where
 {
     availability.set(false);
     let factory = factory?;
-
-    let rx = Box::pin(rx);
     let mut stop = Box::pin(stop);
 
     let svc = match select(factory.create(()), stream_recv(&mut stop)).await {
@@ -356,9 +403,9 @@ where
         svc,
         WorkerSt {
             id,
+            rx,
             factory,
             availability,
-            rx: Box::pin(rx),
             stop: Box::pin(stop),
         },
     ))

ntex-tls/src/openssl/accept.rs

@@ -128,7 +128,7 @@ impl<F: Filter> Service<Io<F>> for SslAcceptorService {
             };
             let io = io.add_filter(filter);
 
-            log::debug!("Accepting tls connection");
+            log::trace!("Accepting tls connection");
             loop {
                 let result = io.with_buf(|buf| {
                     let filter = io.filter();

ntex/CHANGES.md

@@ -1,6 +1,14 @@
 # Changes
 
-## [2.12.3] - 2025-03-xx
+## [2.12.4] - 2025-03-28
+
+* http: Return PayloadError::Incomplete on server disconnect
+
+* web: Expose WebStack for external wrapper support in downstream crates #542
+
+## [2.12.3] - 2025-03-22
+
+* web: Export web::app_service::AppService #534
 
 * http: Add delay for test server availability, could cause connect race
 

ntex/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ntex"
-version = "2.12.2"
+version = "2.12.4"
 authors = ["ntex contributors <team@ntex.rs>"]
 description = "Framework for composable network services"
 readme = "README.md"
@@ -68,11 +68,11 @@ ntex-service = "3.4"
 ntex-macros = "0.1"
 ntex-util = "2.8"
 ntex-bytes = "0.1.27"
-ntex-server = "2.7"
+ntex-server = "2.7.4"
 ntex-h2 = "1.8.6"
 ntex-rt = "0.4.27"
 ntex-io = "2.11"
-ntex-net = "2.5"
+ntex-net = "2.5.10"
 ntex-tls = "2.3"
 
 base64 = "0.22"
@@ -114,6 +114,7 @@ flate2 = { version = "1.0", optional = true }
 [dev-dependencies]
 rand = "0.8"
 time = "0.3"
+oneshot = "0.1"
 futures-util = "0.3"
 tls-openssl = { version = "0.10", package = "openssl" }
 tls-rustls = { version = "0.23", package = "rustls", features = ["ring", "std"], default-features = false }

ntex/src/http/client/h1proto.rs

@@ -1,13 +1,11 @@
-use std::{
-    future::poll_fn, io, io::Write, pin::Pin, task::Context, task::Poll, time::Instant,
-};
+use std::{future::poll_fn, io, io::Write, pin::Pin, task, task::Poll, time::Instant};
 
 use crate::http::body::{BodySize, MessageBody};
 use crate::http::error::PayloadError;
-use crate::http::h1;
 use crate::http::header::{HeaderMap, HeaderValue, HOST};
 use crate::http::message::{RequestHeadType, ResponseHead};
 use crate::http::payload::{Payload, PayloadStream};
+use crate::http::{h1, Version};
 use crate::io::{IoBoxed, RecvError};
 use crate::time::{timeout_checked, Millis};
 use crate::util::{ready, BufMut, Bytes, BytesMut, Stream};
@@ -101,7 +99,13 @@ where
             Ok((head, Payload::None))
         }
         _ => {
-            let pl: PayloadStream = Box::pin(PlStream::new(io, codec, created, pool));
+            let pl: PayloadStream = Box::pin(PlStream::new(
+                io,
+                codec,
+                created,
+                pool,
+                head.version == Version::HTTP_10,
+            ));
             Ok((head, pl.into()))
         }
     }
@@ -137,6 +141,7 @@ pub(super) struct PlStream {
     io: Option<IoBoxed>,
     codec: h1::ClientPayloadCodec,
     created: Instant,
+    http_10: bool,
     pool: Option<Acquired>,
 }
 
@@ -146,12 +151,14 @@ impl PlStream {
         codec: h1::ClientCodec,
         created: Instant,
         pool: Option<Acquired>,
+        http_10: bool,
     ) -> Self {
         PlStream {
             io: Some(io),
             codec: codec.into_payload_codec(),
             created,
             pool,
+            http_10,
         }
     }
 }
@@ -161,41 +168,46 @@ impl Stream for PlStream {
 
     fn poll_next(
         mut self: Pin<&mut Self>,
-        cx: &mut Context<'_>,
+        cx: &mut task::Context<'_>,
     ) -> Poll<Option<Self::Item>> {
         let mut this = self.as_mut();
         loop {
-            return Poll::Ready(Some(
-                match ready!(this.io.as_ref().unwrap().poll_recv(&this.codec, cx)) {
-                    Ok(chunk) => {
-                        if let Some(chunk) = chunk {
-                            Ok(chunk)
-                        } else {
-                            release_connection(
-                                this.io.take().unwrap(),
-                                !this.codec.keepalive(),
-                                this.created,
-                                this.pool.take(),
-                            );
-                            return Poll::Ready(None);
-                        }
+            let item = ready!(this.io.as_ref().unwrap().poll_recv(&this.codec, cx));
+            return Poll::Ready(Some(match item {
+                Ok(chunk) => {
+                    if let Some(chunk) = chunk {
+                        Ok(chunk)
+                    } else {
+                        release_connection(
+                            this.io.take().unwrap(),
+                            !this.codec.keepalive(),
+                            this.created,
+                            this.pool.take(),
+                        );
+                        return Poll::Ready(None);
                     }
-                    Err(RecvError::KeepAlive) => {
-                        Err(io::Error::new(io::ErrorKind::TimedOut, "Keep-alive").into())
+                }
+                Err(RecvError::KeepAlive) => {
+                    Err(io::Error::new(io::ErrorKind::TimedOut, "Keep-alive").into())
+                }
+                Err(RecvError::Stop) => {
+                    Err(io::Error::new(io::ErrorKind::Other, "Dispatcher stopped").into())
+                }
+                Err(RecvError::WriteBackpressure) => {
+                    ready!(this.io.as_ref().unwrap().poll_flush(cx, false))?;
+                    continue;
+                }
+                Err(RecvError::Decoder(err)) => Err(err),
+                Err(RecvError::PeerGone(Some(err))) => {
+                    Err(PayloadError::Incomplete(Some(err)))
+                }
+                Err(RecvError::PeerGone(None)) => {
+                    if this.http_10 {
+                        return Poll::Ready(None);
                     }
-                    Err(RecvError::Stop) => {
-                        Err(io::Error::new(io::ErrorKind::Other, "Dispatcher stopped")
-                            .into())
-                    }
-                    Err(RecvError::WriteBackpressure) => {
-                        ready!(this.io.as_ref().unwrap().poll_flush(cx, false))?;
-                        continue;
-                    }
-                    Err(RecvError::Decoder(err)) => Err(err),
-                    Err(RecvError::PeerGone(Some(err))) => Err(err.into()),
-                    Err(RecvError::PeerGone(None)) => return Poll::Ready(None),
-                },
-            ));
+                    Err(PayloadError::Incomplete(None))
+                }
+            }));
         }
     }
 }

ntex/src/http/client/response.rs

@@ -387,8 +387,8 @@ impl Future for ReadBody {
         let this = self.get_mut();
 
         loop {
-            return match Pin::new(&mut this.stream).poll_next(cx)? {
-                Poll::Ready(Some(chunk)) => {
+            return match Pin::new(&mut this.stream).poll_next(cx) {
+                Poll::Ready(Some(Ok(chunk))) => {
                     if this.limit > 0 && (this.buf.len() + chunk.len()) > this.limit {
                         Poll::Ready(Err(PayloadError::Overflow))
                     } else {
@@ -397,6 +397,7 @@ impl Future for ReadBody {
                     }
                 }
                 Poll::Ready(None) => Poll::Ready(Ok(this.buf.split().freeze())),
+                Poll::Ready(Some(Err(err))) => Poll::Ready(Err(err)),
                 Poll::Pending => {
                     if this.timeout.poll_elapsed(cx).is_ready() {
                         Poll::Ready(Err(PayloadError::Incomplete(Some(

ntex/src/http/h1/decoder.rs

@@ -107,12 +107,12 @@ pub(super) trait MessageType: Sized {
                 };
                 match name {
                     header::CONTENT_LENGTH if content_length.is_some() || chunked => {
-                        log::debug!("multiple Content-Length not allowed");
+                        log::trace!("multiple Content-Length not allowed");
                         return Err(DecodeError::Header);
                     }
                     header::CONTENT_LENGTH => match value.to_str() {
                         Ok(s) if s.trim_start().starts_with('+') => {
-                            log::debug!("illegal Content-Length: {:?}", s);
+                            log::trace!("illegal Content-Length: {:?}", s);
                             return Err(DecodeError::Header);
                         }
                         Ok(s) => {
@@ -121,18 +121,18 @@ pub(super) trait MessageType: Sized {
                                 // headers have been processed to prevent request smuggling issues
                                 content_length = Some(len);
                             } else {
-                                log::debug!("illegal Content-Length: {:?}", s);
+                                log::trace!("illegal Content-Length: {:?}", s);
                                 return Err(DecodeError::Header);
                             }
                         }
                         Err(_) => {
-                            log::debug!("illegal Content-Length: {:?}", value);
+                            log::trace!("illegal Content-Length: {:?}", value);
                             return Err(DecodeError::Header);
                         }
                     },
                     // transfer-encoding
                     header::TRANSFER_ENCODING if seen_te => {
-                        log::debug!("Transfer-Encoding header usage is not allowed");
+                        log::trace!("Transfer-Encoding header usage is not allowed");
                         return Err(DecodeError::Header);
                     }
                     header::TRANSFER_ENCODING if version == Version::HTTP_11 => {
@@ -144,7 +144,7 @@ pub(super) trait MessageType: Sized {
                             } else if s.eq_ignore_ascii_case("identity") {
                                 // allow silently since multiple TE headers are already checked
                             } else {
-                                log::debug!("illegal Transfer-Encoding: {:?}", s);
+                                log::trace!("illegal Transfer-Encoding: {:?}", s);
                                 return Err(DecodeError::Header);
                             }
                         } else {
@@ -266,7 +266,7 @@ impl MessageType for Request {
         // disallow HTTP/1.0 POST requests that do not contain a Content-Length headers
         // see https://datatracker.ietf.org/doc/html/rfc1945#section-7.2.2
         if ver == Version::HTTP_10 && method == Method::POST && length.is_none() {
-            log::debug!("no Content-Length specified for HTTP/1.0 POST request");
+            log::trace!("no Content-Length specified for HTTP/1.0 POST request");
             return Err(DecodeError::Header);
         }
 
@@ -682,7 +682,7 @@ impl ChunkedState {
                 Poll::Ready(Ok(ChunkedState::Size))
             }
             None => {
-                log::debug!("chunk size would overflow u64");
+                log::trace!("chunk size would overflow u64");
                 Poll::Ready(Err(DecodeError::InvalidInput(
                     "Invalid chunk size line: Size is too big",
                 )))

ntex/src/http/test.rs

@@ -252,7 +252,6 @@ where
             Ok(())
         })
     });
-
     let (system, server, addr) = rx.recv().unwrap();
 
     TestServer {

ntex/src/web/config.rs

@@ -68,7 +68,7 @@ pub struct ServiceConfig<Err = DefaultError> {
 }
 
 impl<Err: ErrorRenderer> ServiceConfig<Err> {
-    pub(crate) fn new() -> Self {
+    pub fn new() -> Self {
         Self {
             services: Vec::new(),
             state: Extensions::new(),
@@ -132,7 +132,7 @@ mod tests {
     use crate::http::{Method, StatusCode};
     use crate::util::Bytes;
     use crate::web::test::{call_service, init_service, read_body, TestRequest};
-    use crate::web::{self, App, HttpRequest, HttpResponse};
+    use crate::web::{self, App, DefaultError, HttpRequest, HttpResponse};
 
     #[crate::rt_test]
     async fn test_configure_state() {
@@ -205,4 +205,11 @@ mod tests {
         let resp = call_service(&srv, req).await;
         assert_eq!(resp.status(), StatusCode::OK);
     }
+
+    #[test]
+    fn test_new_service_config() {
+        let cfg: ServiceConfig<DefaultError> = ServiceConfig::new();
+        assert!(cfg.services.is_empty());
+        assert!(cfg.external.is_empty());
+    }
 }

ntex/src/web/mod.rs

@@ -82,7 +82,7 @@ mod route;
 mod scope;
 mod server;
 mod service;
-mod stack;
+pub mod stack;
 pub mod test;
 pub mod types;
 mod util;
@@ -128,6 +128,7 @@ pub mod dev {
     //! The purpose of this module is to alleviate imports of many common
     //! traits by adding a glob import to the top of ntex::web heavy modules:
 
+    pub use crate::web::app_service::AppService;
     pub use crate::web::config::AppConfig;
     pub use crate::web::info::ConnectionInfo;
     pub use crate::web::rmap::ResourceMap;

ntex/src/ws/frame.rs

@@ -116,7 +116,7 @@ impl Parser {
                 return Err(ProtocolError::InvalidLength(length));
             }
             OpCode::Close if length > 125 => {
-                log::debug!("Received close frame with payload length exceeding 125. Morphing to protocol close frame.");
+                log::trace!("Received close frame with payload length exceeding 125. Morphing to protocol close frame.");
                 return Ok(Some((true, OpCode::Close, None)));
             }
             _ => (),

ntex/tests/connect.rs

@@ -1,9 +1,8 @@
 use std::{io, rc::Rc};
 
-use ntex::codec::BytesCodec;
-use ntex::connect::Connect;
 use ntex::io::{types::PeerAddr, Io};
 use ntex::service::{chain_factory, fn_service, Pipeline, ServiceFactory};
+use ntex::{codec::BytesCodec, connect::Connect};
 use ntex::{server::build_test_server, server::test_server, time, util::Bytes};
 
 #[cfg(feature = "rustls")]

ntex/tests/http_awc_client.rs

@@ -508,19 +508,21 @@ async fn test_client_gzip_encoding_large() {
 async fn test_client_gzip_encoding_large_random() {
     let data = rand::thread_rng()
         .sample_iter(&rand::distributions::Alphanumeric)
-        .take(100_000)
+        .take(1_048_500)
         .map(char::from)
         .collect::<String>();
 
     let srv = test::server(|| {
-        App::new().service(web::resource("/").route(web::to(|data: Bytes| async move {
-            let mut e = GzEncoder::new(Vec::new(), Compression::default());
-            e.write_all(&data).unwrap();
-            let data = e.finish().unwrap();
-            HttpResponse::Ok()
-                .header("content-encoding", "gzip")
-                .body(data)
-        })))
+        App::new()
+            .state(web::types::PayloadConfig::default().limit(1_048_576))
+            .service(web::resource("/").route(web::to(|data: Bytes| async move {
+                let mut e = GzEncoder::new(Vec::new(), Compression::default());
+                e.write_all(&data).unwrap();
+                let data = e.finish().unwrap();
+                HttpResponse::Ok()
+                    .header("content-encoding", "gzip")
+                    .body(data)
+            })))
     });
 
     // client request
@@ -528,7 +530,7 @@ async fn test_client_gzip_encoding_large_random() {
     assert!(response.status().is_success());
 
     // read response
-    let bytes = response.body().await.unwrap();
+    let bytes = response.body().limit(1_048_576).await.unwrap();
     assert_eq!(bytes, Bytes::from(data));
 }
 
@@ -680,15 +682,18 @@ async fn client_read_until_eof() {
         for stream in lst.incoming() {
             if let Ok(mut stream) = stream {
                 let mut b = [0; 1000];
-                let _ = stream.read(&mut b).unwrap();
-                let _ = stream
+                log::debug!("Reading request");
+                let res = stream.read(&mut b).unwrap();
+                log::debug!("Read {:?}", res);
+                let res = stream
                     .write_all(b"HTTP/1.0 200 OK\r\nconnection: close\r\n\r\nwelcome!");
+                log::debug!("Sent {:?}", res);
             } else {
                 break;
             }
         }
     });
-    sleep(Millis(300)).await;
+    sleep(Millis(500)).await;
 
     // client request
     let req = Client::build()

ntex/tests/http_openssl.rs

@@ -1,5 +1,6 @@
 #![cfg(feature = "openssl")]
-use std::{io, sync::atomic::AtomicUsize, sync::atomic::Ordering, sync::Arc};
+use std::io;
+use std::sync::{atomic::AtomicUsize, atomic::Ordering, Arc, Mutex};
 
 use futures_util::stream::{once, Stream, StreamExt};
 use tls_openssl::ssl::{AlpnError, SslAcceptor, SslFiletype, SslMethod};
@@ -424,11 +425,12 @@ async fn test_h2_service_error() {
     assert_eq!(bytes, Bytes::from_static(b"error"));
 }
 
-struct SetOnDrop(Arc<AtomicUsize>);
+struct SetOnDrop(Arc<AtomicUsize>, Arc<Mutex<Option<::oneshot::Sender<()>>>>);
 
 impl Drop for SetOnDrop {
     fn drop(&mut self) {
         self.0.fetch_add(1, Ordering::Relaxed);
+        let _ = self.1.lock().unwrap().take().unwrap().send(());
     }
 }
 
@@ -436,17 +438,20 @@ impl Drop for SetOnDrop {
 async fn test_h2_client_drop() -> io::Result<()> {
     let count = Arc::new(AtomicUsize::new(0));
     let count2 = count.clone();
+    let (tx, rx) = ::oneshot::channel();
+    let tx = Arc::new(Mutex::new(Some(tx)));
 
     let srv = test_server(move || {
+        let tx = tx.clone();
         let count = count2.clone();
         HttpService::build()
             .h2(move |req: Request| {
-                let count = count.clone();
+                let st = SetOnDrop(count.clone(), tx.clone());
                 async move {
-                    let _st = SetOnDrop(count);
                     assert!(req.peer_addr().is_some());
                     assert_eq!(req.version(), Version::HTTP_2);
-                    sleep(Seconds(100)).await;
+                    sleep(Seconds(30)).await;
+                    drop(st);
                     Ok::<_, io::Error>(Response::Ok().finish())
                 }
             })
@@ -454,9 +459,9 @@ async fn test_h2_client_drop() -> io::Result<()> {
             .map_err(|_| ())
     });
 
-    let result = timeout(Millis(250), srv.srequest(Method::GET, "/").send()).await;
+    let result = timeout(Millis(1500), srv.srequest(Method::GET, "/").send()).await;
     assert!(result.is_err());
-    sleep(Millis(150)).await;
+    let _ = timeout(Millis(1500), rx).await;
     assert_eq!(count.load(Ordering::Relaxed), 1);
     Ok(())
 }
@@ -539,13 +544,19 @@ async fn test_ws_transport() {
 async fn test_h2_graceful_shutdown() -> io::Result<()> {
     let count = Arc::new(AtomicUsize::new(0));
     let count2 = count.clone();
+    let (tx, rx) = ::oneshot::channel();
+    let tx = Arc::new(Mutex::new(Some(tx)));
 
     let srv = test_server(move || {
+        let tx = tx.clone();
         let count = count2.clone();
         HttpService::build()
             .h2(move |_| {
                 let count = count.clone();
                 count.fetch_add(1, Ordering::Relaxed);
+                if count.load(Ordering::Relaxed) == 2 {
+                    let _ = tx.lock().unwrap().take().unwrap().send(());
+                }
                 async move {
                     sleep(Millis(1000)).await;
                     count.fetch_sub(1, Ordering::Relaxed);
@@ -566,7 +577,7 @@ async fn test_h2_graceful_shutdown() -> io::Result<()> {
         let _ = req.send().await.unwrap();
         sleep(Millis(100000)).await;
     });
-    sleep(Millis(150)).await;
+    let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 2);
 
     let (tx, rx) = oneshot::channel();
@@ -574,8 +585,6 @@ async fn test_h2_graceful_shutdown() -> io::Result<()> {
         srv.stop().await;
         let _ = tx.send(());
     });
-    sleep(Millis(150)).await;
-    assert_eq!(count.load(Ordering::Relaxed), 2);
 
     let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 0);

ntex/tests/http_server.rs

@@ -1,4 +1,4 @@
-use std::sync::{atomic::AtomicUsize, atomic::Ordering, Arc};
+use std::sync::{atomic::AtomicUsize, atomic::Ordering, Arc, Mutex};
 use std::{io, io::Read, io::Write, net};
 
 use futures_util::future::{self, FutureExt};
@@ -723,11 +723,12 @@ async fn test_h1_service_error() {
     assert_eq!(bytes, Bytes::from_static(b"error"));
 }
 
-struct SetOnDrop(Arc<AtomicUsize>);
+struct SetOnDrop(Arc<AtomicUsize>, Option<::oneshot::Sender<()>>);
 
 impl Drop for SetOnDrop {
     fn drop(&mut self) {
         self.0.fetch_add(1, Ordering::Relaxed);
+        let _ = self.1.take().unwrap().send(());
     }
 }
 
@@ -735,24 +736,28 @@ impl Drop for SetOnDrop {
 async fn test_h1_client_drop() -> io::Result<()> {
     let count = Arc::new(AtomicUsize::new(0));
     let count2 = count.clone();
+    let (tx, rx) = ::oneshot::channel();
+    let tx = Arc::new(Mutex::new(Some(tx)));
 
     let srv = test_server(move || {
+        let tx = tx.clone();
         let count = count2.clone();
         HttpService::build().h1(move |req: Request| {
+            let tx = tx.clone();
             let count = count.clone();
             async move {
-                let _st = SetOnDrop(count);
+                let _st = SetOnDrop(count, tx.lock().unwrap().take());
                 assert!(req.peer_addr().is_some());
                 assert_eq!(req.version(), Version::HTTP_11);
-                sleep(Millis(500)).await;
+                sleep(Millis(50000)).await;
                 Ok::<_, io::Error>(Response::Ok().finish())
             }
         })
     });
 
-    let result = timeout(Millis(100), srv.request(Method::GET, "/").send()).await;
+    let result = timeout(Millis(1500), srv.request(Method::GET, "/").send()).await;
     assert!(result.is_err());
-    sleep(Millis(1000)).await;
+    let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 1);
     Ok(())
 }
@@ -761,12 +766,18 @@ async fn test_h1_client_drop() -> io::Result<()> {
 async fn test_h1_gracefull_shutdown() {
     let count = Arc::new(AtomicUsize::new(0));
     let count2 = count.clone();
+    let (tx, rx) = ::oneshot::channel();
+    let tx = Arc::new(Mutex::new(Some(tx)));
 
     let srv = test_server(move || {
+        let tx = tx.clone();
         let count = count2.clone();
         HttpService::build().h1(move |_: Request| {
             let count = count.clone();
             count.fetch_add(1, Ordering::Relaxed);
+            if count.load(Ordering::Relaxed) == 2 {
+                let _ = tx.lock().unwrap().take().unwrap().send(());
+            }
             async move {
                 sleep(Millis(1000)).await;
                 count.fetch_sub(1, Ordering::Relaxed);
@@ -781,7 +792,7 @@ async fn test_h1_gracefull_shutdown() {
     let mut stream2 = net::TcpStream::connect(srv.addr()).unwrap();
     let _ = stream2.write_all(b"GET /index.html HTTP/1.1\r\n\r\n");
 
-    sleep(Millis(150)).await;
+    let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 2);
 
     let (tx, rx) = oneshot::channel();
@@ -789,8 +800,6 @@ async fn test_h1_gracefull_shutdown() {
         srv.stop().await;
         let _ = tx.send(());
     });
-    sleep(Millis(150)).await;
-    assert_eq!(count.load(Ordering::Relaxed), 2);
 
     let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 0);
@@ -800,12 +809,18 @@ async fn test_h1_gracefull_shutdown() {
 async fn test_h1_gracefull_shutdown_2() {
     let count = Arc::new(AtomicUsize::new(0));
     let count2 = count.clone();
+    let (tx, rx) = ::oneshot::channel();
+    let tx = Arc::new(Mutex::new(Some(tx)));
 
     let srv = test_server(move || {
+        let tx = tx.clone();
         let count = count2.clone();
         HttpService::build().finish(move |_: Request| {
             let count = count.clone();
             count.fetch_add(1, Ordering::Relaxed);
+            if count.load(Ordering::Relaxed) == 2 {
+                let _ = tx.lock().unwrap().take().unwrap().send(());
+            }
             async move {
                 sleep(Millis(1000)).await;
                 count.fetch_sub(1, Ordering::Relaxed);
@@ -820,17 +835,14 @@ async fn test_h1_gracefull_shutdown_2() {
     let mut stream2 = net::TcpStream::connect(srv.addr()).unwrap();
     let _ = stream2.write_all(b"GET /index.html HTTP/1.1\r\n\r\n");
 
-    sleep(Millis(150)).await;
-    assert_eq!(count.load(Ordering::Relaxed), 2);
+    let _ = rx.await;
+    assert_eq!(count.load(Ordering::Acquire), 2);
 
     let (tx, rx) = oneshot::channel();
     rt::spawn(async move {
         srv.stop().await;
         let _ = tx.send(());
     });
-    sleep(Millis(150)).await;
-    assert_eq!(count.load(Ordering::Relaxed), 2);
-
     let _ = rx.await;
     assert_eq!(count.load(Ordering::Relaxed), 0);
 }