mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

openmetrics/histograms: improve code clarity

Browse source 
If buckets thresholds are to be taken as "less than or equal to", then
using the less than or equal to operator seems sensible.
This commit is contained in:
Kim Alvefur 2021-12-27 16:05:12 +01:00
parent 569df0581e
commit 079a39c216
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
util/statistics.lua
View file

@ -102,7 +102,7 @@ end
function histogram_metric_mt:sample(value)
-- According to the I-D, values must be part of all buckets
for i, bucket in pairs(self) do
if "number" == type(i) and bucket.threshold >= value then
if "number" == type(i) and value <= bucket.threshold then
bucket.count = bucket.count + 1
end
end

2
util/statsd.lua
View file

@ -115,7 +115,7 @@ end
function histogram_metric_mt:sample(value)
-- According to the I-D, values must be part of all buckets
for i, bucket in pairs(self) do
if "number" == type(i) and bucket.threshold >= value then
if "number" == type(i) and value <= bucket.threshold then
bucket.count = bucket.count + 1
self._impl:push_counter_delta(bucket._full_name, 1)
end