mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_ping: Fix double response to internal ping

Browse source 
When responding to a ping from elsewhere in the same Prosody the send
function will be host_send from core.hostmanager, which does not return
anything. Tailcalling it therefore lets the iq event fall trough to
handle_unhandled_stanza in core.stanza_router, which responds with an
error. This error also goes into handle_unhandled_stanza which discards
it.

Noticed because I have a module that points out when a stanza error
reply is created without a text argument.
This commit is contained in:
Kim Alvefur 2020-02-21 23:30:47 +01:00
parent aa6a550ceb
commit 0b3056c448
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/mod_ping.lua
View file

@ -11,7 +11,8 @@ local st = require "util.stanza";
module:add_feature("urn:xmpp:ping");
local function ping_handler(event)
return event.origin.send(st.reply(event.stanza));
event.origin.send(st.reply(event.stanza));
return true;
end
module:hook("iq-get/bare/urn:xmpp:ping:ping", ping_handler);