mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-05 14:17:37 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_roster: Use value returned by pairs() during roster iteration to avoid dozens of wasteful table lookups

Browse source
This commit is contained in:
Matthew Wild 2010-07-05 02:20:37 +01:00
parent 88a0d25218
commit 180f79f833
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugins/mod_roster.lua
View file

@ -42,15 +42,15 @@ module:add_iq_handler("c2s", "jabber:iq:roster",
if not (client_ver and server_ver) or client_ver ~= server_ver then if not (client_ver and server_ver) or client_ver ~= server_ver then
roster:query("jabber:iq:roster"); roster:query("jabber:iq:roster");
-- Client does not support versioning, or has stale roster -- Client does not support versioning, or has stale roster
for jid in pairs(session.roster) do for jid, item in pairs(session.roster) do
if jid ~= "pending" and jid then if jid ~= "pending" and jid then
roster:tag("item", { roster:tag("item", {
jid = jid, jid = jid,
subscription = session.roster[jid].subscription, subscription = item.subscription,
ask = session.roster[jid].ask, ask = item.ask,
name = session.roster[jid].name, name = item.name,
}); });
for group in pairs(session.roster[jid].groups) do for group in pairs(item.groups) do
roster:tag("group"):text(group):up(); roster:tag("group"):text(group):up();
end end
roster:up(); -- move out from item roster:up(); -- move out from item