mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

util.stanza: Require a type attribute for iq stanzas

Browse source
This commit is contained in:
Kim Alvefur 2018-12-28 20:49:01 +01:00
parent 4da406588e
commit 20429527b1
2 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
spec/util_stanza_spec.lua
View file

@ -95,19 +95,30 @@ describe("util.stanza", function()
describe("#iq()", function()
it("should create an iq stanza", function()
local i = st.iq({ id = "foo" });
local i = st.iq({ type = "get", id = "foo" });
assert.are.equal("iq", i.name);
assert.are.equal("foo", i.attr.id);
assert.are.equal("get", i.attr.type);
end);
it("should reject stanzas with no attributes", function ()
assert.has.error_match(function ()
st.iq();
end, "attributes");
end);
it("should reject stanzas with no id", function ()
assert.has.error_match(function ()
st.iq();
st.iq({ type = "get" });
end, "id attribute");
end);
it("should reject stanzas with no type", function ()
assert.has.error_match(function ()
st.iq({ foo = "bar" });
end, "id attribute");
st.iq({ id = "foo" });
end, "type attribute");
end);
end);

8
util/stanza.lua
View file

@ -423,9 +423,15 @@ local function message(attr, body)
end
end
local function iq(attr)
if not (attr and attr.id) then
if not attr then
error("iq stanzas require id and type attributes");
end
if not attr.id then
error("iq stanzas require an id attribute");
end
if not attr.type then
error("iq stanzas require a type attribute");
end
return new_stanza("iq", attr);
end