mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

MUC: Don't default component admins to being room owners

Browse source 
This change has various technical and social benefits. If ownership of a MUC
is really needed, it can be gained using the 'Set affiliation' ad-hoc command
or prosodyctl shell.

Example client incompatibility with the old behaviour:

  - https://github.com/monal-im/Monal/issues/1085
This commit is contained in:
Matthew Wild 2024-06-18 15:08:30 +01:00
parent aa6b79c20c
commit 29148cfe9c
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
CHANGES
View file

@ -16,6 +16,10 @@ TRUNK
### MUC
- Component admins are no longer room owners by default. This can be reverted
to the old behaviour with `component_admins_as_room_owners = true`, but this
has known incompatibilities with some clients. Instead, use the shell or
ad-hoc commands to gain ownership of rooms when necessary.
- Permissions updates:
- Room creation restricted to local users (of the parent host) by default
- restrict_room_creation = true restricts to admins, false disables all restrictions

2
plugins/muc/mod_muc.lua
View file

@ -125,7 +125,7 @@ module:default_permissions("prosody:guest", {
":list-rooms";
});
if module:get_option_boolean("component_admins_as_room_owners", true) then
if module:get_option_boolean("component_admins_as_room_owners", false) then
-- Monkey patch to make server admins room owners
local _get_affiliation = room_mt.get_affiliation;
function room_mt:get_affiliation(jid)