mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-04 05:37:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_storage_sql: Fix summary API with Postgres (fixes #1766)

Browse source 
The ORDER BY and LIMIT clauses are not needed and don't even make much
sense. This part was most likely a leftover from the :find method.

Tested with sqlite and postgres 14
This commit is contained in:
Kim Alvefur 2022-07-22 19:09:50 +02:00
parent 3ee6df83b0
commit 2dbbce2382
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/mod_storage_sql.lua
View file

@ -544,8 +544,7 @@ function archive_store:summary(username, query)
SELECT DISTINCT "with", COUNT(*), MIN("when"), MAX("when")
FROM "prosodyarchive"
WHERE %s
GROUP BY "with"
ORDER BY "sort_id" %s%s;
GROUP BY "with";
]];
local args = { host, user or "", store, };
local where = { "\"host\" = ?", "\"user\" = ?", "\"store\" = ?", };
@ -558,8 +557,7 @@ function archive_store:summary(username, query)
args[#args+1] = query.limit;
end
sql_query = sql_query:format(t_concat(where, " AND "), query.reverse
and "DESC" or "ASC", query.limit and " LIMIT ?" or "");
sql_query = sql_query:format(t_concat(where, " AND "));
return engine:select(sql_query, unpack(args));
end);
if not ok then return ok, result end