mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

util.sql: Remove built-in engine caching. This is the wrong layer to do this, and unintentionally sharing connections could cause problems (e.g. when interleaving multiple queries and result fetching)

Browse source
This commit is contained in:
Matthew Wild 2015-06-03 15:57:46 +01:00
parent 41996240ed
commit 3edc813e77
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
util/sql.lua
View file

@ -283,14 +283,9 @@ function db2uri(params)
path = params.database,
};
end
local engine_cache = {}; -- TODO make weak valued
function create_engine(self, params)
local url = db2uri(params);
if not engine_cache[url] then
local engine = setmetatable({ url = url, params = params }, engine_mt);
engine_cache[url] = engine;
end
return engine_cache[url];
function create_engine(self, params, onconnect)
return setmetatable({ url = db2uri(params), params = params, onconnect = onconnect }, engine_mt);
end
return _M;