mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

util.stanza: Switch from asserts to if's, improve performance, errors and tests

Browse source
This commit is contained in:
Matthew Wild 2018-03-18 11:32:00 +00:00
parent 1490ff5472
commit 65f4b853a0
2 changed files with 69 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

63
spec/util_stanza_spec.lua
View file

@ -165,38 +165,49 @@ describe("util.stanza", function()
end);
end);
describe("#invalid", function ()
it("name should be rejected", function ()
assert.has_error(function ()
st.stanza(1234);
describe("should reject #invalid", function ()
local invalid_names = {
["empty string"] = "", ["characters"] = "<>";
}
local invalid_data = {
["number"] = 1234, ["table"] = {};
["utf8"] = string.char(0xF4, 0x90, 0x80, 0x80);
};
for value_type, value in pairs(invalid_names) do
it(value_type.." in tag names", function ()
assert.error_matches(function ()
st.stanza(value);
end, value_type);
end);
assert.has_error(function ()
st.stanza({});
it(value_type.." in attribute names", function ()
assert.error_matches(function ()
st.stanza("valid", { [value] = "valid" });
end, value_type);
end);
assert.has_error(function ()
st.stanza();
end
for value_type, value in pairs(invalid_data) do
it(value_type.." in tag names", function ()
assert.error_matches(function ()
st.stanza(value);
end, value_type);
end);
assert.has_error(function ()
st.stanza("");
it(value_type.." in attribute names", function ()
assert.error_matches(function ()
st.stanza("valid", { [value] = "valid" });
end, value_type);
end);
assert.has_error(function ()
st.stanza(string.char(0xC0));
it(value_type.." in attribute values", function ()
assert.error_matches(function ()
st.stanza("valid", { valid = value });
end, value_type);
end);
assert.has_error(function ()
st.stanza(string.char(0xF4, 0x90, 0x80, 0x80));
it(value_type.." in text node", function ()
assert.error_matches(function ()
st.stanza("valid"):text(value);
end, value_type);
end);
assert.has_error(function ()
st.stanza("<>");
end);
assert.has_error(function ()
st.stanza("&");
end);
end);
it("UTF-8 should be rejected", function ()
assert.has_error(function ()
st.stanza("tag"):text("hello "..string.char(0xF4, 0x90, 0x80, 0x80).." world");
end);
end);
end
end);
describe("#is_stanza", function ()