mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-05 22:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_auth_internal_{plain,hashed}: Use constant-time string comparison for secrets

Browse source
This commit is contained in:
Matthew Wild 2021-05-10 16:50:24 +01:00
parent d126ee88bc
commit 6a54d2d2c4
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/mod_auth_internal_plain.lua
View file

@ -9,6 +9,7 @@
local usermanager = require "core.usermanager";
local new_sasl = require "util.sasl".new;
local saslprep = require "util.encodings".stringprep.saslprep;
local secure_equals = require "util.hashes".equals;
local log = module._log;
local host = module.host;
@ -26,7 +27,7 @@ function provider.test_password(username, password)
return nil, "Password fails SASLprep.";
end
if password == saslprep(credentials.password) then
if secure_equals(password, saslprep(credentials.password)) then
return true;
else
return nil, "Auth failed. Invalid username or password.";