mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

net.resolvers.basic: Move IP literal check to constructor

Browse source 
This is to prepare for fixing #1459. An IPv6 literal in [ ] brackets
does not pass IDNA and resolving it fails there.
This commit is contained in:
Kim Alvefur 2019-11-24 04:23:51 +01:00
parent 7ac5e467ba
commit 7c056be161
1 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

25
net/resolvers/basic.lua
View file

@ -33,16 +33,6 @@ function methods:next(cb)
self:next(cb);
end
local is_ip = inet_pton(self.hostname);
if is_ip then
if #is_ip == 16 then
cb(self.conn_type.."6", self.hostname, self.port, self.extra);
elseif #is_ip == 4 then
cb(self.conn_type.."4", self.hostname, self.port, self.extra);
end
return;
end
-- Resolve DNS to target list
local dns_resolver = adns.resolver();
dns_resolver:lookup(function (answer)
@ -65,11 +55,24 @@ function methods:next(cb)
end
local function new(hostname, port, conn_type, extra)
local ascii_host = idna_to_ascii(hostname);
local targets = nil;
local is_ip = inet_pton(hostname);
if is_ip then
if #is_ip == 16 then
targets = { { conn_type.."6", hostname, port, extra } };
elseif #is_ip == 4 then
targets = { { conn_type.."4", hostname, port, extra } };
end
end
return setmetatable({
hostname = idna_to_ascii(hostname);
hostname = ascii_host;
port = port;
conn_type = conn_type or "tcp";
extra = extra;
targets = targets;
}, resolver_mt);
end