mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_bookmarks: Reduce error about not having bookmarks to debug (thanks tom)

Browse source 
This is happens if the account is new and doesn't have any bookmarks
yet, which is not a problem.

Rarely seen since most clients currently use the older version of
XEP-0084 stored in XEP-0049 rather than in PEP, but at least one
(Converse.js )does.

One scenario in which this would show up often is with Converse.js as a
guest chat using anonymous authentication, where all "accounts" would
always be new and not have any bookmarks. This scenario probably does
not need to have mod_bookmarks at all, but if enabled globally it would
likely become loaded onto the VirtualHost unless explicitly disabled.
This commit is contained in:
Kim Alvefur 2022-07-26 23:44:33 +02:00
parent 9f51add3a8
commit 96301b2229
2 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/mod_bookmarks.lua
View file

@ -87,7 +87,11 @@ local function on_retrieve_legacy_pep(event)
local service = mod_pep.get_pep_service(username);
local ok, ret = service:get_items(namespace, session.full_jid);
if not ok then
module:log("error", "Failed to retrieve PEP bookmarks of %s: %s", jid, ret);
if ret == "item-not-found" then
module:log("debug", "Got no PEP bookmarks item for %s, returning empty private bookmarks", jid);
else
module:log("error", "Failed to retrieve PEP bookmarks of %s: %s", jid, ret);
end
session.send(st.error_reply(stanza, "cancel", ret, "Failed to retrieve bookmarks from PEP"));
return true;
end