mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_admin_shell: Ensure account has role before it is usable

Browse source 
By creating the account first without a password it can't be used until
the role has set. This is most important for restricted accounts, as a
failure to set the role would lead to the account having more privileges
than indented.
This commit is contained in:
Kim Alvefur 2022-08-18 19:00:01 +02:00
parent 742153c555
commit 96e172167d
1 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

24
plugins/mod_admin_shell.lua
View file

@ -1390,16 +1390,24 @@ function def_env.user:create(jid, password, role)
elseif um.user_exists(username, host) then
return nil, "User exists";
end
local ok, err = um.create_user(username, password, host);
if ok then
if ok and role then
local role_ok, rerr = um.set_user_role(jid, host, role);
if not role_ok then return nil, "User created, but could not set role: " .. tostring(rerr); end
end
return true, "User created";
else
local ok, err = um.create_user(username, nil, host);
if not ok then
return nil, "Could not create user: "..err;
end
if role then
local role_ok, rerr = um.set_user_role(jid, host, role);
if not role_ok then
return nil, "Could not set role: " .. tostring(rerr);
end
end
local ok, err = um.set_password(username, password, host, nil);
if not ok then
return nil, "Could not set password for user: "..err;
end
return true, "User created";
end
function def_env.user:delete(jid)