mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_bookmarks: Block publishing to older XEP-0402 v0.3.0 node

Browse source 
Having both the :0 and :1 nodes would be especially awkward, since there
is no upgrade path for this case. In theory, these should be rare since
no clients should have been doing XEP-0402 unless mod_bookmarks(2) was
enabled. This was guesstimated to be rare with most clients doing
XEP-0048 with Private XML.
This commit is contained in:
Kim Alvefur 2022-01-10 22:15:55 +01:00
parent bdd8dddff5
commit ba50691289
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
plugins/mod_bookmarks.lua
View file

@ -10,6 +10,7 @@ local mod_pep = module:depends "pep";
local private_storage = module:open_store("private", "map");
local namespace = "urn:xmpp:bookmarks:1";
local namespace_old = "urn:xmpp:bookmarks:0";
local namespace_private = "jabber:iq:private";
local namespace_legacy = "storage:bookmarks";
local xmlns_pubsub = "http://jabber.org/protocol/pubsub";
@ -271,7 +272,13 @@ local function on_publish_legacy_pep(event)
end
local publish = pubsub:get_child("publish");
if publish == nil or publish.attr.node ~= namespace_legacy then
if publish == nil then return end
if publish.attr.node == namespace_old then
session.send(st.error_reply(stanza, "modify", "not-allowed",
"Your client does XEP-0402 version 0.3.0 but 0.4.0+ is required"));
return true;
end
if publish.attr.node ~= namespace_legacy then
return;
end