mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-04 05:37:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_smacks: Bounce unhandled stanzas from local origin (fix #1759)

Browse source 
Sending stanzas with a remote session as origin when the stanzas have a
local JID in the from attribute trips validation in core.stanza_router,
leading to warnings:
> Received a stanza claiming to be from remote.example, over a stream authed for localhost.example

Using module:send() uses the local host as origin, which is fine here.
This commit is contained in:
Kim Alvefur 2022-05-27 14:45:35 +02:00
parent 568aa79441
commit d7e7558bae
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/mod_smacks.lua
View file

@ -55,7 +55,6 @@ local watchdog = require "util.watchdog";
local it = require"util.iterators";
local sessionmanager = require "core.sessionmanager";
local core_process_stanza = prosody.core_process_stanza;
local xmlns_errors = "urn:ietf:params:xml:ns:xmpp-stanzas";
local xmlns_delay = "urn:xmpp:delay";
@ -420,7 +419,7 @@ local function handle_unacked_stanzas(session)
if not module:fire_event("delivery/failure", { session = session, stanza = stanza }) then
if stanza.attr.type ~= "error" and stanza.attr.from ~= session.full_jid then
local reply = st.error_reply(stanza, "cancel", "recipient-unavailable");
core_process_stanza(session, reply);
module:send(reply);
end
end
end