mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_external_services: Validate required attributes on credentials requests

Browse source
This commit is contained in:
Kim Alvefur 2021-08-29 23:26:19 +02:00
parent 4ddf47aaf0
commit d915f98800
2 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
plugins/mod_external_services.lua
View file

@ -175,7 +175,7 @@ local function handle_credentials(event)
local action = stanza.tags[1];
if origin.type ~= "c2s" then
origin.send(st.error_reply(stanza, "auth", "forbidden"));
origin.send(st.error_reply(stanza, "auth", "forbidden", "The 'port' and 'type' attributes are required."));
return true;
end
@ -188,6 +188,11 @@ local function handle_credentials(event)
local requested_credentials = {};
for service in action:childtags("service") do
if not service.attr.type or not service.attr.host then
origin.send(st.error_reply(stanza, "modify", "bad-request"));
return true;
end
table.insert(requested_credentials, {
type = service.attr.type;
host = service.attr.host;

14
spec/scansion/extdisco.scs
View file

@ -52,6 +52,20 @@ Romeo receives:
</credentials>
</iq>
Romeo sends:
<iq type='get' xml:lang='sv' id='lx5' to='localhost'>
<credentials xmlns='urn:xmpp:extdisco:2'>
<service host='default.example' />
</credentials>
</iq>
Romeo receives:
<iq type='error' id='lx5' from='localhost'>
<error type='modify'>
<bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
</error>
</iq>
Romeo disconnects
# recording ended on 2020-07-18T16:47:57Z