mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-05 06:07:37 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

mod_external_services: Report overall status as a module status

Browse source 
Because during startup, if all items are provided by a different module
(e.g. mod_turn_external) then this would log a scary warning even if
everything is fine after that other module has been loaded.

This way, any persistent problematic state is reported in the console.
Errors with individual items should still be reported by prepare().

Now, if you load mod_external_services alone without configuring any
services, no error or warning is reported in the log, but maybe that's
not so bad with it reported in the console.
This commit is contained in:
Kim Alvefur 2021-06-21 22:43:26 +02:00
parent 44675f7dbf
commit eded7e2738
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/mod_external_services.lua
View file

@ -103,12 +103,14 @@ function module.load()
local extras = module:get_host_items("external_service"); local extras = module:get_host_items("external_service");
local services = ( configured_services + extras ) / prepare; local services = ( configured_services + extras ) / prepare;
if #services == 0 then if #services == 0 then
module:log("warn", "No services configured or all had errors"); module:set_status("warn", "No services configured or all had errors");
end end
end end
module:handle_items("external_service", function(added) module:handle_items("external_service", function(added)
prepare(added.item); if prepare(added.item) then
module:set_status("core", "OK");
end
end, module.load); end, module.load);
-- Ensure only valid items are added in events -- Ensure only valid items are added in events