mirrors/prosody
1
0
Fork 0
mirror of https://github.com/bjc/prosody.git synced 2025-04-03 21:27:38 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

util.pubsub: Fix behavior of persist_items disabled

Browse source 
When set to 'false' there is no need for a persistence interface at all,
since items are not persisted after being broadcast.

Had started wondering if maybe the behavior was wrong, after reading
parts of XEP-0060 that pointed in that direction.

Some discussion of this can be found in logs of
xmpp:xsf@muc.xmpp.org?join from around 2021-07-20

Thanks to Ralph for confirming.
This commit is contained in:
Kim Alvefur 2021-07-22 21:01:11 +02:00
parent 8116134258
commit ffeeffd35c
2 changed files with 41 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
spec/util_pubsub_spec.lua
View file

@ -509,4 +509,23 @@ describe("util.pubsub", function ()
end);
end);
describe("persist_items", function()
it("can be disabled", function()
local broadcaster = spy.new(function(notif_type, node_name, subscribers, item) -- luacheck: ignore 212
end);
local service = pubsub.new { node_defaults = { persist_items = false }, broadcaster = broadcaster }
local ok = service:create("node", true)
assert.truthy(ok);
local ok = service:publish("node", true, "1", "item");
assert.truthy(ok);
assert.spy(broadcaster).was_called();
local ok, items = service:get_items("node", true);
assert.truthy(ok);
assert.same(items, {});
end);
end)
end);