Kim Alvefur
d7fa4fadcf
mod_smacks: Back out def20683c161
...
The attempted fix completely broke everything after resumption.
2021-12-13 21:15:06 +01:00
Kim Alvefur
816ed3d739
mod_smacks: Update reference to session from send()
...
a86ae74da96c caused the stanza queue to double on resumption because
session.send() keeps a reference to the session which is what gets
passed to filters, so the added flag was not seen in the filter.
2021-12-13 19:48:42 +01:00
Kim Alvefur
283042d7c3
mod_smacks: Include reason for destroying session on hibernation timeout
...
To aid in debugging
2021-12-12 18:38:40 +01:00
Kim Alvefur
ca41268d26
mod_smacks: Refactor, simplify, optimize
...
Since reply.attr.to will be the .attr.from of the input we can check
this earlier and avoid constructing the reply at all.
2021-12-03 01:02:02 +01:00
Kim Alvefur
9f22150bc8
mod_smacks: Use function to construct error reply
...
Did error_reply() not exist when mod_smacks was first created?
2021-12-03 00:59:23 +01:00
Kim Alvefur
16f0d48795
mod_smacks: Remove obsolete comment
...
It dates back to the initial commit in prosody-modules 9a7671720dec
2021-12-02 14:28:52 +01:00
Kim Alvefur
f5b0606514
mod_smacks: Avoid duplicated queueing using flag on session instead of stanza
...
Mutating the stanza like this is Really Bad Practice.
2021-12-02 13:56:50 +01:00
Kim Alvefur
89b37d4e0a
mod_smacks: Remove dead conditional
...
`cached_stanza` can't be falsy because util.stanza.clone() would have
thrown rather than return nil, or `._cached=true` would have.
2021-12-02 13:49:42 +01:00
Kim Alvefur
9f3feb39f9
mod_smacks: Ensure hibernating session is not connected
...
Turns out that if you destroy a session from inside prosody, it goes
into hibernation but stays connected and continues processing stanzas.
2021-12-02 03:03:44 +01:00
Kim Alvefur
d34e453ec3
mod_smacks: Reorder imports etc
...
Mostly sorted by name of import (sort -k4) and grouped by kind
2021-12-01 23:18:18 +01:00
Kim Alvefur
7182a72911
mod_smacks: Fix empty cache check
...
In Lua, every value except `nil` and `false` are considered true in
boolean expressions, even `0` as here, which means this was dead code.
2021-12-01 23:03:11 +01:00
Kim Alvefur
a7783d452a
mod_smacks: Use stanza type checking function for correctness
...
Non-stanza tables with an 'attr' field might be rare in Prosody, but
better to be Correct
2021-12-01 21:04:32 +01:00
Kim Alvefur
15ef5fb400
mod_smacks: Remove redundant fields
...
Given that the registry is scoped per user and the module is scoped per
host, there seems no point to checking or storing both username and host
here.
2021-12-01 16:26:53 +01:00
Kim Alvefur
b9a8bc1148
mod_smacks: Factor out formatting of 'h' value
2021-12-01 16:20:40 +01:00
Kim Alvefur
129520cd56
mod_smacks: Remove dead legacy code for 0.10
2021-12-01 15:27:55 +01:00
Kim Alvefur
85602802b2
mod_smacks: Use new pre-session-close event instead of monkeypatch
...
Much cleaner.
2021-12-01 15:09:11 +01:00
Kim Alvefur
10664a8877
mod_smacks: Remove left-over debug logging
...
Wrong level, missing argument, whatever it was meant to shed light on
has been resolved and forgotten.
2021-11-27 12:53:56 +01:00
Kim Alvefur
bbfe15dac5
mod_smacks: Optimize scheduling of ack requests
...
Taking advantage of the new callbacks added in dcf38ac6a38c and
9c450185bac1 avoids extra timers, extra syscalls and sending the `<r>`
in its own TCP segment, improving efficiency.
2021-11-24 21:27:49 +01:00
Kim Alvefur
faff262ac8
mod_smacks: Refactor ack requesting to avoid some timer roundtrips
...
The function was too large to comprehend! Breaking it up helps
readability and reuse.
The timer round rip is only to avoid ordering weirdness when sending
from inside a stanza filter. No need when handling <r> and <a>
CSI interactions both boiled down to sending an <r> immediately.
2021-11-24 21:27:49 +01:00
Kim Alvefur
d4398ef21d
mod_smacks: Fix timer lifetimes to follow session instead of module
...
module:add_timer() creates a timer that stops working after the module
is reloaded or unloaded, in order to prevent leaks. However, when the
timers control vital session behavior, breakage occurs after reload.
E.g. sessions would stop requesting acks and stop responding to acks.
2021-11-24 21:27:45 +01:00
Kim Alvefur
ea20acace0
mod_smacks: Clean up compat code etc
...
Unstoppable stoppable timer compat not needed since 26f54b462601 ca 0.11.0
module:hook_stanza was renamed in 2012
No idea what was going on with the indentation and such
2021-11-24 21:27:49 +01:00
Kim Alvefur
5e86776f0c
mod_smacks: Import from prosody-modules @ eb63890ae8fc
2021-11-16 21:15:22 +01:00
