From b9d65e89f0daefffc4656c7347842402633c51a2 Mon Sep 17 00:00:00 2001 From: zyachel Date: Sun, 12 Jun 2022 12:49:08 +0530 Subject: [PATCH] fix: fix errors in fetchers --- fetchers/fetcher.js | 3 ++- fetchers/getAnswers.js | 1 - fetchers/getTopic.js | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fetchers/fetcher.js b/fetchers/fetcher.js index b884845..b9bfde4 100644 --- a/fetchers/fetcher.js +++ b/fetchers/fetcher.js @@ -34,7 +34,8 @@ const fetcher = async resourceStr => { .html() ?.match(/"\{.*\}"/m)?.[0]; }); - if (!rawData) throw new Error("couldn't retrieve data"); + if (!rawData || !Object.entries(rawData).length) + throw new AppError("couldn't retrieve data", 500); const data = JSON.parse(rawData); diff --git a/fetchers/getAnswers.js b/fetchers/getAnswers.js index 18f3535..37cd8b0 100644 --- a/fetchers/getAnswers.js +++ b/fetchers/getAnswers.js @@ -11,7 +11,6 @@ import fetcher from './fetcher.js'; const getAnswers = async slug => { // getting data and destructuring it in case it exists const res = await fetcher(slug); - if (!Object.entries(res).length) throw new Error('no data received!'); const { data: { question: rawData }, diff --git a/fetchers/getTopic.js b/fetchers/getTopic.js index 1495ea6..ecd3721 100644 --- a/fetchers/getTopic.js +++ b/fetchers/getTopic.js @@ -10,7 +10,6 @@ import fetcher from './fetcher.js'; const getTopic = async slug => { // getting data and destructuring it in case it exists, else throwing an error const res = await fetcher(`topic/${slug}`); - if (!Object.entries(res).length) throw new Error('no data received!'); const { data: { topic: rawData },