mirrors/quetre
1
0
Fork 0
mirror of https://github.com/zyachel/quetre.git synced 2025-04-03 21:17:36 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: send a meaningful error response in case an answer/topic can't be fetched

Browse source 
sometimes URL is malinformed(eg: accessing topic/some-name instead of profile/some-name).
other times it's Quora that doesn't populate their JSON.
In all these cases, fetcher script returns an empty object.
So, sending meaningful error messages might help the user.
This commit is contained in:
zyachel 2022-06-24 17:42:59 +05:30
parent fb7d8034fe
commit e7c83bd06e
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
fetchers/getAnswers.js
View file

@ -18,8 +18,8 @@ const getAnswers = async slug => {
if (!rawData)
throw new AppError(
"Couldn't find such an answer. Maybe check the URL?",
400
"Answers couldn't be fetched. Recheck the URL, or resend the request if you believe the URL is correct.",
404
);
// array containing all the answers with metadata

5
fetchers/getTopic.js
View file

@ -16,7 +16,10 @@ const getTopic = async slug => {
} = JSON.parse(res);
if (!rawData)
throw new AppError("couldn't find such a topic. Maybe check the URL?", 400);
throw new AppError(
"Topic details couldn't be fetched. Recheck the URL, or resend the request if you believe the URL is correct.",
404
);
const data = {
tid: rawData.tid,