From 7930b19809f00c99705949027550add74068da3b Mon Sep 17 00:00:00 2001 From: Matthew Esposito Date: Mon, 3 Feb 2025 00:47:25 -0500 Subject: [PATCH] fix: fix clippy + tests --- src/client.rs | 6 ------ src/main.rs | 18 +++--------------- src/utils.rs | 4 ++-- 3 files changed, 5 insertions(+), 23 deletions(-) diff --git a/src/client.rs b/src/client.rs index fa32fc0..76369ca 100644 --- a/src/client.rs +++ b/src/client.rs @@ -544,12 +544,6 @@ async fn test_obfuscated_share_link() { assert_eq!(canonical_path(share_link, 3).await, Ok(Some(canonical_link))); } -#[tokio::test(flavor = "multi_thread")] -async fn test_share_link_strip_json() { - let link = "/17krzvz".into(); - let canonical_link = "/comments/17krzvz".into(); - assert_eq!(canonical_path(link, 3).await, Ok(Some(canonical_link))); -} #[tokio::test(flavor = "multi_thread")] async fn test_private_sub() { let link = json("/r/suicide/about.json?raw_json=1".into(), true).await; diff --git a/src/main.rs b/src/main.rs index a109560..165f0cb 100644 --- a/src/main.rs +++ b/src/main.rs @@ -108,20 +108,8 @@ async fn main() { let matches = Command::new("Redlib") .version(env!("CARGO_PKG_VERSION")) .about("Private front-end for Reddit written in Rust ") - .arg( - Arg::new("ipv4-only") - .short('4') - .long("ipv4-only") - .help("Listen on IPv4 only") - .num_args(0), - ) - .arg( - Arg::new("ipv6-only") - .short('6') - .long("ipv6-only") - .help("Listen on IPv6 only") - .num_args(0), - ) + .arg(Arg::new("ipv4-only").short('4').long("ipv4-only").help("Listen on IPv4 only").num_args(0)) + .arg(Arg::new("ipv6-only").short('6').long("ipv6-only").help("Listen on IPv6 only").num_args(0)) .arg( Arg::new("redirect-https") .short('r') @@ -392,7 +380,7 @@ async fn main() { Some("best" | "hot" | "new" | "top" | "rising" | "controversial") => subreddit::community(req).await, // Short link for post - Some(id) if (5..8).contains(&id.len()) => match canonical_path(format!("/{id}"), 3).await { + Some(id) if (5..8).contains(&id.len()) => match canonical_path(format!("/comments/{id}"), 3).await { Ok(path_opt) => match path_opt { Some(path) => Ok(redirect(&path)), None => error(req, "Post ID is invalid. It may point to a post on a community that has been banned.").await, diff --git a/src/utils.rs b/src/utils.rs index cf226b9..867f73f 100644 --- a/src/utils.rs +++ b/src/utils.rs @@ -1549,10 +1549,10 @@ fn test_rewriting_bullet_list() { - Color Temp Medium How`s your monitor by the way? Any IPS bleed whatsoever? I either got lucky or the panel is pretty good, 0 bleed for me, just the usual IPS glow. How about the pixels? I see the pixels even at one meter away, especially on Microsoft Edge's icon for example, the blue background is just blocky, don't know why.

"#; -let output = r#"

Hi, I've bought this very same monitor and found no calibration whatsoever. I have an ICC profile that has been set up since I've installed its driver from the LG website and it works ok. I also used http://www.lagom.nl/lcd-test/ to calibrate it. After some good tinkering I've found the following settings + the color profile from the driver gets me past all the tests perfectly: + let output = r#"

Hi, I've bought this very same monitor and found no calibration whatsoever. I have an ICC profile that has been set up since I've installed its driver from the LG website and it works ok. I also used http://www.lagom.nl/lcd-test/ to calibrate it. After some good tinkering I've found the following settings + the color profile from the driver gets me past all the tests perfectly:

  • Brightness 50 (still have to settle on this one, it's personal preference, it controls the backlight, not the colors)
  • Contrast 70 (which for me was the default one)
  • Picture mode Custom
  • Super resolution + Off (it looks horrible anyway)
  • Sharpness 50 (default one I think)
  • Black level High (low messes up gray colors)
  • DFC Off
  • Response Time Middle (personal preference, https://www.blurbusters.com/ show horrible overdrive with it on high)
  • Freesync doesn't matter
  • Black stabilizer 50
  • Gamma setting on 0
  • Color Temp Medium
How`s your monitor by the way? Any IPS bleed whatsoever? I either got lucky or the panel is pretty good, 0 bleed for me, just the usual IPS glow. How about the pixels? I see the pixels even at one meter away, especially on Microsoft Edge's icon for example, the blue background is just blocky, don't know why.

"#; assert_eq!(render_bullet_lists(input), output); -} \ No newline at end of file +}