mirrors/thiserror
1
0
Fork 0
mirror of https://github.com/dtolnay/thiserror.git synced 2025-04-03 21:07:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Improve diagnostic on {_} in format string

Browse source
This commit is contained in:
David Tolnay 2024-11-04 22:00:42 -05:00
parent 4a79e0121e
commit 58cc36e69f
No known key found for this signature in database
GPG key ID: F9BA143B95FF6D82
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
impl/src/fmt.rs
View file

@ -78,7 +78,7 @@ impl Display<'_> {
let formatvar = match &member {
MemberUnraw::Unnamed(index) => IdentUnraw::new(format_ident!("__field{}", index)),
MemberUnraw::Named(ident) => {
if user_named_args.contains(ident) {
if user_named_args.contains(ident) || ident == "_" {
// Refers to a named argument written by the user, not to field.
out += &ident.to_string();
continue;

8
tests/ui/display-underscore.stderr
View file

@ -1,5 +1,7 @@
error: in expressions, `_` can only be used on the left-hand side of an assignment
--> tests/ui/display-underscore.rs:4:9
error: invalid format string: invalid argument name `_`
--> tests/ui/display-underscore.rs:4:11
|
4 | #[error("{_}")]
| ^^^^^ `_` not allowed here
| ^ invalid argument name in format string
|
= note: argument name cannot be a single underscore