mirrors/thiserror
1
0
Fork 0
mirror of https://github.com/dtolnay/thiserror.git synced 2025-04-04 21:37:57 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #408 from dtolnay/assoctype

Browse source 
Generate trait bounds on associated types
This commit is contained in:
David Tolnay 2025-01-08 11:45:42 -08:00 • committed by GitHub
commit 6cd87bc228
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
impl/src/generics.rs
View file

@ -25,13 +25,14 @@ impl<'a> ParamsInScope<'a> {
fn crawl(in_scope: &ParamsInScope, ty: &Type, found: &mut bool) { fn crawl(in_scope: &ParamsInScope, ty: &Type, found: &mut bool) {
if let Type::Path(ty) = ty { if let Type::Path(ty) = ty {
if ty.qself.is_none() { if let Some(qself) = &ty.qself {
if let Some(ident) = ty.path.get_ident() { crawl(in_scope, &qself.ty, found);
if in_scope.names.contains(ident) { } else {
let front = ty.path.segments.first().unwrap();
if front.arguments.is_none() && in_scope.names.contains(&front.ident) {
*found = true; *found = true;
} }
} }
}
for segment in &ty.path.segments { for segment in &ty.path.segments {
if let PathArguments::AngleBracketed(arguments) = &segment.arguments { if let PathArguments::AngleBracketed(arguments) = &segment.arguments {
for arg in &arguments.args { for arg in &arguments.args {

19
tests/test_generics.rs
View file

@ -1,6 +1,7 @@
#![allow(clippy::needless_late_init, clippy::uninlined_format_args)] #![allow(clippy::needless_late_init, clippy::uninlined_format_args)]
use core::fmt::{self, Debug, Display}; use core::fmt::{self, Debug, Display};
use core::str::FromStr;
use thiserror::Error; use thiserror::Error;
pub struct NoFormat; pub struct NoFormat;
@ -160,6 +161,24 @@ pub struct StructFromGeneric<E> {
#[error(transparent)] #[error(transparent)]
pub struct StructTransparentGeneric<E>(pub E); pub struct StructTransparentGeneric<E>(pub E);
// Should expand to:
//
// impl<T: FromStr> Display for AssociatedTypeError<T>
// where
// T::Err: Display;
//
// impl<T: FromStr> Error for AssociatedTypeError<T>
// where
// Self: Debug + Display;
//
#[derive(Error, Debug)]
pub enum AssociatedTypeError<T: FromStr> {
#[error("couldn't parse matrix")]
Other,
#[error("couldn't parse entry: {0}")]
EntryParseError(T::Err),
}
// Regression test for https://github.com/dtolnay/thiserror/issues/345 // Regression test for https://github.com/dtolnay/thiserror/issues/345
#[test] #[test]
fn test_no_bound_on_named_fmt() { fn test_no_bound_on_named_fmt() {