mirrors/thiserror
1
0
Fork 0
mirror of https://github.com/dtolnay/thiserror.git synced 2025-04-03 04:47:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #396 from dtolnay/deprecatedfrom

Browse source 
Suppress deprecation warning on generated From impls
This commit is contained in:
David Tolnay 2024-12-08 10:39:10 -08:00 • committed by GitHub
commit e9a9085150
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
impl/src/expand.rs
View file

@ -170,10 +170,9 @@ fn impl_struct(input: Struct) -> TokenStream {
let source_var = Ident::new("source", span);
let body = from_initializer(from_field, backtrace_field, &source_var);
quote_spanned! {span=>
#[allow(unused_qualifications, clippy::needless_lifetimes)]
#[allow(deprecated, unused_qualifications, clippy::needless_lifetimes)]
#[automatically_derived]
impl #impl_generics ::core::convert::From<#from> for #ty #ty_generics #where_clause {
#[allow(deprecated)]
fn from(#source_var: #from) -> Self {
#ty #body
}
@ -435,10 +434,9 @@ fn impl_enum(input: Enum) -> TokenStream {
let source_var = Ident::new("source", span);
let body = from_initializer(from_field, backtrace_field, &source_var);
Some(quote_spanned! {span=>
#[allow(unused_qualifications, clippy::needless_lifetimes)]
#[allow(deprecated, unused_qualifications, clippy::needless_lifetimes)]
#[automatically_derived]
impl #impl_generics ::core::convert::From<#from> for #ty #ty_generics #where_clause {
#[allow(deprecated)]
fn from(#source_var: #from) -> Self {
#ty::#variant #body
}

10
tests/test_lints.rs
View file

@ -64,6 +64,16 @@ fn test_deprecated() {
Variant,
}
#[derive(Error, Debug)]
pub enum DeprecatedFrom {
#[error(transparent)]
Variant(
#[from]
#[allow(deprecated)]
DeprecatedStruct,
),
}
#[allow(deprecated)]
let _: DeprecatedStruct;
#[allow(deprecated)]