error: this expression borrows a reference (`&ast::Field`) that is immediately dereferenced by the compiler
--> impl/src/prop.rs:68:25
|
68 | return Some(&field);
| ^^^^^^ help: change this to: `field`
|
= note: `-D clippy::needless-borrow` implied by `-D clippy::all`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&ast::Field`) that is immediately dereferenced by the compiler
--> impl/src/prop.rs:77:25
|
77 | return Some(&field);
| ^^^^^^ help: change this to: `field`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&ast::Field`) that is immediately dereferenced by the compiler
--> impl/src/prop.rs:82:70
|
82 | Member::Named(ident) if ident == "source" => return Some(&field),
| ^^^^^^ help: change this to: `field`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&ast::Field`) that is immediately dereferenced by the compiler
--> impl/src/prop.rs:92:25
|
92 | return Some(&field);
| ^^^^^^ help: change this to: `field`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&ast::Field`) that is immediately dereferenced by the compiler
--> impl/src/prop.rs:97:25
|
97 | return Some(&field);
| ^^^^^^ help: change this to: `field`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&syn::Type`) that is immediately dereferenced by the compiler
--> impl/src/valid.rs:191:41
|
191 | if contains_non_static_lifetime(&source_field.ty) {
| ^^^^^^^^^^^^^^^^ help: change this to: `source_field.ty`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
I do not find that it makes the code clearer in this case, given the
related `if` branch right above.
error: manual implementation of `Option::map`
--> impl/src/ast.rs:145:16
|
145 | } else if let Some(transparent) = &self.transparent {
| ________________^
146 | | Some(transparent.span)
147 | | } else {
148 | | None
149 | | }
| |_________^ help: try this: `self.transparent.as_ref().map(|transparent| transparent.span)`
|
= note: `-D clippy::manual-map` implied by `-D clippy::all`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
When a macro generates part of the derive input, the call-site hygiene
may be different than the hygiene of a field. Therefore, we need to
be sure to use the same hygiene information for any identifiers we
generate, instead of relying on the hygiene from a particular span
via `quote_spanned!`
warning: lint `clippy::block_in_if_condition_stmt` has been renamed to `clippy::blocks_in_if_conditions`
--> impl/src/lib.rs:1:10
|
1 | #![allow(clippy::block_in_if_condition_stmt, clippy::range_plus_one)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::blocks_in_if_conditions`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
