Release 2.0.12

Clippy elidable_lifetime_names lint

.github/workflows/ci.yml

@@ -41,6 +41,7 @@ jobs:
       - run: cargo test --workspace --exclude thiserror_no_std_test
       - run: cargo test --manifest-path tests/no-std/Cargo.toml
         if: matrix.rust != '1.70.0'
+      - run: cargo test --no-default-features
       - uses: actions/upload-artifact@v4
         if: matrix.rust == 'nightly' && always()
         with:

.gitignore

@@ -1,3 +1,2 @@
-/target
-**/*.rs.bk
-Cargo.lock
+/target/
+/Cargo.lock

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "thiserror"
-version = "2.0.9"
+version = "2.0.12"
 authors = ["David Tolnay <dtolnay@gmail.com>"]
 categories = ["rust-patterns"]
 description = "derive(Error)"
@@ -28,7 +28,7 @@ default = ["std"]
 std = []
 
 [dependencies]
-thiserror-impl = { version = "=2.0.9", path = "impl" }
+thiserror-impl = { version = "=2.0.12", path = "impl" }
 
 [dev-dependencies]
 anyhow = "1.0.73"
@@ -41,4 +41,9 @@ members = ["impl", "tests/no-std"]
 
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
-rustdoc-args = ["--generate-link-to-definition"]
+rustdoc-args = [
+    "--generate-link-to-definition",
+    "--extern-html-root-url=core=https://doc.rust-lang.org",
+    "--extern-html-root-url=alloc=https://doc.rust-lang.org",
+    "--extern-html-root-url=std=https://doc.rust-lang.org",
+]

impl/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "thiserror-impl"
-version = "2.0.9"
+version = "2.0.12"
 authors = ["David Tolnay <dtolnay@gmail.com>"]
 description = "Implementation detail of the `thiserror` crate"
 edition = "2021"
@@ -18,4 +18,10 @@ syn = "2.0.87"
 
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]
-rustdoc-args = ["--generate-link-to-definition"]
+rustdoc-args = [
+    "--generate-link-to-definition",
+    "--extern-html-root-url=core=https://doc.rust-lang.org",
+    "--extern-html-root-url=alloc=https://doc.rust-lang.org",
+    "--extern-html-root-url=std=https://doc.rust-lang.org",
+    "--extern-html-root-url=proc_macro=https://doc.rust-lang.org",
+]

impl/src/expand.rs

@@ -181,7 +181,12 @@ fn impl_struct(input: Struct) -> TokenStream {
             }
         };
         Some(quote! {
-            #[allow(deprecated, unused_qualifications, clippy::needless_lifetimes)]
+            #[allow(
+                deprecated,
+                unused_qualifications,
+                clippy::elidable_lifetime_names,
+                clippy::needless_lifetimes,
+            )]
             #from_impl
         })
     });
@@ -451,7 +456,12 @@ fn impl_enum(input: Enum) -> TokenStream {
             }
         };
         Some(quote! {
-            #[allow(deprecated, unused_qualifications, clippy::needless_lifetimes)]
+            #[allow(
+                deprecated,
+                unused_qualifications,
+                clippy::elidable_lifetime_names,
+                clippy::needless_lifetimes,
+            )]
             #from_impl
         })
     });

impl/src/generics.rs

@@ -25,11 +25,12 @@ impl<'a> ParamsInScope<'a> {
 
 fn crawl(in_scope: &ParamsInScope, ty: &Type, found: &mut bool) {
     if let Type::Path(ty) = ty {
-        if ty.qself.is_none() {
-            if let Some(ident) = ty.path.get_ident() {
-                if in_scope.names.contains(ident) {
-                    *found = true;
-                }
+        if let Some(qself) = &ty.qself {
+            crawl(in_scope, &qself.ty, found);
+        } else {
+            let front = ty.path.segments.first().unwrap();
+            if front.arguments.is_none() && in_scope.names.contains(&front.ident) {
+                *found = true;
             }
         }
         for segment in &ty.path.segments {

src/aserror.rs

@@ -44,7 +44,7 @@ impl<'a> AsDynError<'a> for dyn Error + Send + Sync + UnwindSafe + 'a {
 #[doc(hidden)]
 pub trait Sealed {}
 impl<T: Error> Sealed for T {}
-impl<'a> Sealed for dyn Error + 'a {}
-impl<'a> Sealed for dyn Error + Send + 'a {}
-impl<'a> Sealed for dyn Error + Send + Sync + 'a {}
-impl<'a> Sealed for dyn Error + Send + Sync + UnwindSafe + 'a {}
+impl Sealed for dyn Error + '_ {}
+impl Sealed for dyn Error + Send + '_ {}
+impl Sealed for dyn Error + Send + Sync + '_ {}
+impl Sealed for dyn Error + Send + Sync + UnwindSafe + '_ {}

src/lib.rs

@@ -9,8 +9,6 @@
 //! This library provides a convenient derive macro for the standard library's
 //! [`std::error::Error`] trait.
 //!
-//! [`std::error::Error`]: https://doc.rust-lang.org/std/error/trait.Error.html
-//!
 //! <br>
 //!
 //! # Example
@@ -259,8 +257,9 @@
 //!   [`anyhow`]: https://github.com/dtolnay/anyhow
 
 #![no_std]
-#![doc(html_root_url = "https://docs.rs/thiserror/2.0.9")]
+#![doc(html_root_url = "https://docs.rs/thiserror/2.0.12")]
 #![allow(
+    clippy::elidable_lifetime_names,
     clippy::module_name_repetitions,
     clippy::needless_lifetimes,
     clippy::return_self_not_must_use,

tests/test_backtrace.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "std")]
 #![cfg_attr(thiserror_nightly_testing, feature(error_generic_member_access))]
 
 use thiserror::Error;

tests/test_display.rs

@@ -1,4 +1,5 @@
 #![allow(
+    clippy::elidable_lifetime_names,
     clippy::needless_lifetimes,
     clippy::needless_raw_string_hashes,
     clippy::trivially_copy_pass_by_ref,

tests/test_expr.rs

@@ -1,6 +1,7 @@
 #![allow(clippy::iter_cloned_collect, clippy::uninlined_format_args)]
 
 use core::fmt::Display;
+#[cfg(feature = "std")]
 use std::path::PathBuf;
 use thiserror::Error;
 
@@ -90,6 +91,7 @@ fn test_rustup() {
 }
 
 // Regression test for https://github.com/dtolnay/thiserror/issues/335
+#[cfg(feature = "std")]
 #[test]
 #[allow(non_snake_case)]
 fn test_assoc_type_equality_constraint() {

tests/test_generics.rs

@@ -1,6 +1,7 @@
 #![allow(clippy::needless_late_init, clippy::uninlined_format_args)]
 
 use core::fmt::{self, Debug, Display};
+use core::str::FromStr;
 use thiserror::Error;
 
 pub struct NoFormat;
@@ -160,6 +161,24 @@ pub struct StructFromGeneric<E> {
 #[error(transparent)]
 pub struct StructTransparentGeneric<E>(pub E);
 
+// Should expand to:
+//
+//     impl<T: FromStr> Display for AssociatedTypeError<T>
+//     where
+//         T::Err: Display;
+//
+//     impl<T: FromStr> Error for AssociatedTypeError<T>
+//     where
+//         Self: Debug + Display;
+//
+#[derive(Error, Debug)]
+pub enum AssociatedTypeError<T: FromStr> {
+    #[error("couldn't parse matrix")]
+    Other,
+    #[error("couldn't parse entry: {0}")]
+    EntryParseError(T::Err),
+}
+
 // Regression test for https://github.com/dtolnay/thiserror/issues/345
 #[test]
 fn test_no_bound_on_named_fmt() {

tests/test_lints.rs

@@ -33,7 +33,7 @@ fn test_unused_qualifications() {
 #[test]
 fn test_needless_lifetimes() {
     #![allow(dead_code)]
-    #![deny(clippy::needless_lifetimes)]
+    #![deny(clippy::elidable_lifetime_names, clippy::needless_lifetimes)]
 
     #[derive(Error, Debug)]
     #[error("...")]

tests/test_option.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "std")]
 #![cfg_attr(thiserror_nightly_testing, feature(error_generic_member_access))]
 
 #[cfg(thiserror_nightly_testing)]

tests/test_path.rs

@@ -1,3 +1,5 @@
+#![cfg(feature = "std")]
+
 use core::fmt::Display;
 use ref_cast::RefCast;
 use std::path::{Path, PathBuf};