mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

rttstats: don't set initial RTT after having obtained a measurement (#3852)

Browse source
This commit is contained in:
Marten Seemann 2023-05-28 15:09:25 +03:00 • committed by GitHub
parent cb3453db25
commit 02013caaa4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/utils/rtt_stats.go
View file

@ -103,8 +103,12 @@ func (r *RTTStats) SetMaxAckDelay(mad time.Duration) {
// SetInitialRTT sets the initial RTT.
// It is used during the 0-RTT handshake when restoring the RTT stats from the session state.
func (r *RTTStats) SetInitialRTT(t time.Duration) {
// On the server side, by the time we get to process the session ticket,
// we might already have obtained an RTT measurement.
// This can happen if we received the ClientHello in multiple pieces, and one of those pieces was lost.
// Discard the restored value. A fresh measurement is always better.
if r.hasMeasurement {
panic("initial RTT set after first measurement")
return
}
r.smoothedRTT = t
r.latestRTT = t

10
internal/utils/rtt_stats_test.go
View file

@ -154,4 +154,14 @@ var _ = Describe("RTT stats", func() {
Expect(rttStats.SmoothedRTT()).To(Equal(200 * time.Millisecond))
Expect(rttStats.MeanDeviation()).To(Equal(100 * time.Millisecond))
})
It("doesn't restore the RTT if we already have a measurement", func() {
const rtt = 10 * time.Millisecond
rttStats.UpdateRTT(rtt, 0, time.Now())
Expect(rttStats.LatestRTT()).To(Equal(rtt))
Expect(rttStats.SmoothedRTT()).To(Equal(rtt))
rttStats.SetInitialRTT(time.Minute)
Expect(rttStats.LatestRTT()).To(Equal(rtt))
Expect(rttStats.SmoothedRTT()).To(Equal(rtt))
})
})