mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix writing of multiple headers with the same name

Browse source
This commit is contained in:
chestnutprog 2016-10-04 23:21:33 +08:00 • committed by Lucas Clemente
parent f511eb0001
commit 02b50e2ffb
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
h2quic/response_writer.go
View file

@ -49,7 +49,9 @@ func (w *responseWriter) WriteHeader(status int) {
enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
for k, v := range w.header {
enc.WriteField(hpack.HeaderField{Name: strings.ToLower(k), Value: v[0]})
for index := range v {
enc.WriteField(hpack.HeaderField{Name: strings.ToLower(k), Value: v[index]})
}
}
utils.Infof("Responding with %d", status)

10
h2quic/response_writer_test.go
View file

@ -48,6 +48,16 @@ var _ = Describe("Response Writer", func() {
}))
})
It("writes multiple headers with the same name", func() {
w.Header().Add("set-cookie", "test1=1; Max-Age=7200; path=/")
w.Header().Add("set-cookie", "test2=2; Max-Age=7200; path=/")
w.WriteHeader(http.StatusTeapot)
Expect(headerStream.Bytes()).To(Equal([]byte{0x00, 0x00, 0x33, 0x01, 0x04, 0x00, 0x00, 0x00, 0x05,
0x48, 0x03, 0x34, 0x31, 0x38, 0x77, 0x95, 0x49, 0x50, 0x90, 0xc0, 0x1f, 0xb5, 0x34, 0x0f, 0xca, 0xd0, 0xcc,
0x58, 0x1d, 0x10, 0x01, 0xf6, 0xa5, 0x63, 0x4c, 0xf0, 0x31, 0x77, 0x95, 0x49, 0x50, 0x91, 0x40, 0x2f, 0xb5,
0x34, 0x0f, 0xca, 0xd0, 0xcc, 0x58, 0x1d, 0x10, 0x01, 0xf6, 0xa5, 0x63, 0x4c, 0xf0, 0x31}))
})
It("writes data", func() {
n, err := w.Write([]byte("foobar"))
Expect(n).To(Equal(6))