Merge pull request #2799 from lucas-clemente/optional-quic-trace

only include quic-trace when the quictrace build flag is set

interface.go

@@ -256,8 +256,9 @@ type Config struct {
 	StatelessResetKey []byte
 	// KeepAlive defines whether this peer will periodically send a packet to keep the connection alive.
 	KeepAlive bool
-	// QUIC Event Tracer.
+	// QUIC Event Tracer (see https://github.com/google/quic-trace).
-	// Warning: Experimental. This API should not be considered stable and will change soon.
+	// Warning: Support for quic-trace will soon be dropped in favor of qlog.
+	// It is disabled by default. Use the "quictrace" build tag to enable (e.g. go build -tags quictrace).
 	QuicTracer quictrace.Tracer
 	Tracer     logging.Tracer
 }

quictrace/null_tracer.go

@@ -0,0 +1,17 @@
+// +build !quictrace
+
+package quictrace
+
+import "github.com/lucas-clemente/quic-go/internal/protocol"
+
+// NewTracer returns a new Tracer that doesn't do anything.
+func NewTracer() Tracer {
+	return &nullTracer{}
+}
+
+type nullTracer struct{}
+
+var _ Tracer = &nullTracer{}
+
+func (t *nullTracer) Trace(protocol.ConnectionID, Event) {}
+func (t *nullTracer) GetAllTraces() map[string][]byte    { return make(map[string][]byte) }

quictrace/tracer.go

@@ -1,3 +1,5 @@
+// +build quictrace
+
 package quictrace
 
 import (