mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

replace stream.LenOfDataForWriting by HasDataForWriting

Browse source 
The return value (the length of data for writing) was only used to
determine if the stream has data for writing. Therefore it's easier to
just return a bool.

No functional change expected.
This commit is contained in:
Marten Seemann 2017-12-07 18:19:11 +07:00
parent 62a664f5f4
commit 085624be20
5 changed files with 40 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

12
stream.go
View file

@ -19,7 +19,7 @@ type streamI interface {
AddStreamFrame(*wire.StreamFrame) error
RegisterRemoteError(error, protocol.ByteCount) error
LenOfDataForWriting() protocol.ByteCount
HasDataForWriting() bool
GetDataForWriting(maxBytes protocol.ByteCount) []byte
GetWriteOffset() protocol.ByteCount
Finished() bool
@ -263,14 +263,12 @@ func (s *stream) GetWriteOffset() protocol.ByteCount {
return s.writeOffset
}
func (s *stream) LenOfDataForWriting() protocol.ByteCount {
// HasDataForWriting says if there's stream available to be dequeued for writing
func (s *stream) HasDataForWriting() bool {
s.mutex.Lock()
var l protocol.ByteCount
if s.err == nil {
l = protocol.ByteCount(len(s.dataForWriting))
}
hasData := s.err == nil && len(s.dataForWriting) > 0
s.mutex.Unlock()
return l
return hasData
}
func (s *stream) GetDataForWriting(maxBytes protocol.ByteCount) []byte {