mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 04:07:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

move GSO control message handling to the oobConn (#4056)

Browse source 
* move GSO control message handling to the oobConn

* disable OOB test on Windows

* improve GSO tests

* update ooConn.WritePacket comment
This commit is contained in:
Marten Seemann 2023-08-31 14:49:27 +07:00 • committed by GitHub
parent d7334c16e7
commit 090e505aa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 134 additions and 115 deletions
Download patch file Download diff file Expand all files Collapse all files

15
send_queue.go
View file

@ -1,9 +1,8 @@
package quic
import "github.com/quic-go/quic-go/internal/protocol"
type sender interface {
Send(p *packetBuffer, packetSize protocol.ByteCount)
// Send sends a packet. GSO is only used if gsoSize > 0.
Send(p *packetBuffer, gsoSize uint16)
Run() error
WouldBlock() bool
Available() <-chan struct{}
@ -11,8 +10,8 @@ type sender interface {
}
type queueEntry struct {
buf *packetBuffer
size protocol.ByteCount
buf *packetBuffer
gsoSize uint16
}
type sendQueue struct {
@ -40,9 +39,9 @@ func newSendQueue(conn sendConn) sender {
// Send sends out a packet. It's guaranteed to not block.
// Callers need to make sure that there's actually space in the send queue by calling WouldBlock.
// Otherwise Send will panic.
func (h *sendQueue) Send(p *packetBuffer, size protocol.ByteCount) {
func (h *sendQueue) Send(p *packetBuffer, gsoSize uint16) {
select {
case h.queue <- queueEntry{buf: p, size: size}:
case h.queue <- queueEntry{buf: p, gsoSize: gsoSize}:
// clear available channel if we've reached capacity
if len(h.queue) == sendQueueCapacity {
select {
@ -77,7 +76,7 @@ func (h *sendQueue) Run() error {
// make sure that all queued packets are actually sent out
shouldClose = true
case e := <-h.queue:
if err := h.conn.Write(e.buf.Data, e.size); err != nil {
if err := h.conn.Write(e.buf.Data, e.gsoSize); err != nil {
// This additional check enables:
// 1. Checking for "datagram too large" message from the kernel, as such,
// 2. Path MTU discovery,and