mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

make sure that the ACK delay time is always a positive value

Browse source 
On systems without a monotonic clock, this value could become negative,
which would cause a uint underflow.
This commit is contained in:
Marten Seemann 2019-08-14 16:43:55 +07:00
parent 7df59b855f
commit 0b0eb2432a
2 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/ackhandler/received_packet_tracker_test.go
View file

@ -207,6 +207,13 @@ var _ = Describe("Received Packet Tracker", func() {
Expect(ack.DelayTime).To(BeNumerically("~", 1337*time.Millisecond, 50*time.Millisecond))
})
It("uses a 0 delay time if the delay would be negative", func() {
tracker.ReceivedPacket(0, time.Now().Add(time.Hour), true)
ack := tracker.GetAckFrame()
Expect(ack).ToNot(BeNil())
Expect(ack.DelayTime).To(BeZero())
})
It("saves the last sent ACK", func() {
tracker.ReceivedPacket(1, time.Time{}, true)
ack := tracker.GetAckFrame()