mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-06 05:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

reset the RTO timer when queueing an RTO retransmission

Browse source
This commit is contained in:
Lucas Clemente 2016-08-14 15:13:27 +02:00
parent 61e06de838
commit 157055e99c
4 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ackhandler/sent_packet_handler.go
View file

@ -329,6 +329,8 @@ func (h *sentPacketHandler) maybeQueuePacketsRTO() {
h.congestion.OnRetransmissionTimeout(true)
utils.Debugf("\tQueueing packet 0x%x for retransmission (RTO)", packet.PacketNumber)
h.queuePacketForRetransmission(el)
// Reset the RTO timer here, since it's not clear that this packet contained any retransmittable frames
h.lastSentPacketTime = time.Now()
return
}
}

1
ackhandler/sent_packet_handler_test.go
View file

@ -878,6 +878,7 @@ var _ = Describe("SentPacketHandler", func() {
handler.maybeQueuePacketsRTO()
Expect(handler.retransmissionQueue).To(HaveLen(1))
Expect(handler.retransmissionQueue[0].PacketNumber).To(Equal(p.PacketNumber))
Expect(time.Now().Sub(handler.lastSentPacketTime)).To(BeNumerically("<", time.Second/2))
})
})

2
ackhandlerlegacy/sent_packet_handler.go
View file

@ -344,6 +344,8 @@ func (h *sentPacketHandler) maybeQueuePacketsRTO() {
h.congestion.OnRetransmissionTimeout(true)
utils.Debugf("\tQueueing packet 0x%x for retransmission (RTO)", packet.PacketNumber)
h.queuePacketForRetransmission(packet)
// Reset the RTO timer here, since it's not clear that this packet contained any retransmittable frames
h.lastSentPacketTime = time.Now()
return
}
}

1
ackhandlerlegacy/sent_packet_handler_test.go
View file

@ -778,6 +778,7 @@ var _ = Describe("SentPacketHandler", func() {
handler.maybeQueuePacketsRTO()
Expect(handler.retransmissionQueue).To(HaveLen(1))
Expect(handler.retransmissionQueue[0]).To(Equal(p))
Expect(time.Now().Sub(handler.lastSentPacketTime)).To(BeNumerically("<", time.Second/2))
})
It("does not queue retransmittedpackets", func() {