mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

don't enqueue stream for sending on reordered MAX_STREAM_DATA frames (#4269)

Browse source
This commit is contained in:
Marten Seemann 2024-02-03 13:02:13 +07:00 • committed by GitHub
parent 07ec3245bd
commit 198de32ef6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 47 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

20
send_stream_test.go
View file

@ -682,7 +682,7 @@ var _ = Describe("Send Stream", func() {
})
It("says when it has data for sending", func() {
mockFC.EXPECT().UpdateSendWindow(gomock.Any())
mockFC.EXPECT().UpdateSendWindow(gomock.Any()).Return(true)
mockSender.EXPECT().onHasStreamData(streamID)
done := make(chan struct{})
go func() {
@ -698,6 +698,24 @@ var _ = Describe("Send Stream", func() {
str.closeForShutdown(nil)
Eventually(done).Should(BeClosed())
})
It("doesn't say it has data for sending if the MAX_STREAM_DATA frame was reordered", func() {
mockFC.EXPECT().UpdateSendWindow(gomock.Any()).Return(false) // reordered frame
mockSender.EXPECT().onHasStreamData(streamID)
done := make(chan struct{})
go func() {
defer GinkgoRecover()
_, err := str.Write([]byte("foobar"))
Expect(err).ToNot(HaveOccurred())
close(done)
}()
waitForWrite()
// don't expect any calls to onHasStreamData
str.updateSendWindow(42)
// make sure the Write go routine returns
str.closeForShutdown(nil)
Eventually(done).Should(BeClosed())
})
})
Context("stream cancellations", func() {