mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

http3: discard negative content-length header when writing response (#3983)

Browse source 
* response writer: discard negative content-length header

* shorten comment

---------

Co-authored-by: Marten Seemann <martenseemann@gmail.com>
This commit is contained in:
WeidiDeng 2023-07-21 02:42:37 +08:00 • committed by GitHub
parent 5a22ac8970
commit 2183283622
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
http3/response_writer.go
View file

@ -64,9 +64,10 @@ func (w *responseWriter) WriteHeader(status int) {
w.header.Set("Date", time.Now().UTC().Format(http.TimeFormat)) w.header.Set("Date", time.Now().UTC().Format(http.TimeFormat))
} }
// Content-Length checking // Content-Length checking
// use ParseUint instead of ParseInt, as negative values are invalid
if clen := w.header.Get("Content-Length"); clen != "" { if clen := w.header.Get("Content-Length"); clen != "" {
if cl, err := strconv.ParseInt(clen, 10, 64); err == nil { if cl, err := strconv.ParseUint(clen, 10, 63); err == nil {
w.contentLen = cl w.contentLen = int64(cl)
} else { } else {
// emit a warning for malformed Content-Length and remove it // emit a warning for malformed Content-Length and remove it
w.logger.Errorf("Malformed Content-Length %s", clen) w.logger.Errorf("Malformed Content-Length %s", clen)