mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 20:27:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix detection when the QUIC version is negotiated

Browse source
This commit is contained in:
Marten Seemann 2016-12-14 18:27:05 +07:00
parent 099e01f410
commit 2377b3a111
No known key found for this signature in database
GPG key ID: 3603F40B121FCDEA
2 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
client.go
View file

@ -129,6 +129,12 @@ func (c *Client) handlePacket(packet []byte) error {
return nil
}
// this is the first packet after the client sent a packet with the VersionFlag set
// if the server doesn't send a version negotiation packet, it supports the suggested version
if !hdr.VersionFlag && !c.versionNegotiated {
c.versionNegotiated = true
}
if hdr.VersionFlag {
// check if the server sent the offered version in supported versions
for _, v := range hdr.SupportedVersions {

14
client_test.go
View file

@ -150,6 +150,20 @@ var _ = Describe("Client", func() {
return packet
}
It("recognizes that a packet without VersionFlag means that the server accepted the suggested version", func() {
ph := PublicHeader{
PacketNumber: 1,
PacketNumberLen: protocol.PacketNumberLen2,
ConnectionID: 0x1337,
}
b := &bytes.Buffer{}
err := ph.Write(b, protocol.VersionWhatever, protocol.PerspectiveServer)
Expect(err).ToNot(HaveOccurred())
err = client.handlePacket(b.Bytes())
Expect(err).ToNot(HaveOccurred())
Expect(client.versionNegotiated).To(BeTrue())
})
It("changes the version after receiving a version negotiation packet", func() {
startUDPConn()
newVersion := protocol.Version35