mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-03 04:07:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

http3: panic in ResponseWriter.WriteHeader for invalid status codes (#3984)

Browse source 
* response writer: panic for invalid status code

* add tests

* readd imports

* readd imports

* fix imports
This commit is contained in:
WeidiDeng 2023-07-22 00:50:51 +08:00 • committed by GitHub
parent 2bcfe5bc4b
commit 2c0e7e02b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
http3/response_writer.go
View file

@ -3,6 +3,7 @@ package http3
import (
"bufio"
"bytes"
"fmt"
"net/http"
"strconv"
"strings"
@ -55,7 +56,12 @@ func (w *responseWriter) WriteHeader(status int) {
return
}
if status < 100 || status >= 200 {
// http status must be 3 digits
if status < 100 || status > 999 {
panic(fmt.Sprintf("invalid WriteHeader code %v", status))
}
if status >= 200 {
w.headerWritten = true
// Add Date header.
// This is what the standard library does.

5
http3/response_writer_test.go
View file

@ -178,4 +178,9 @@ var _ = Describe("Response Writer", func() {
Expect(n).To(Equal(0))
Expect(err).To(Equal(http.ErrContentLength))
})
It(`panics when writing invalid status`, func() {
Expect(func() { rw.WriteHeader(99) }).To(Panic())
Expect(func() { rw.WriteHeader(1000) }).To(Panic())
})
})