mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 20:57:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2892 from lucas-clemente/optimize-packet-handler-map-map-keys

Browse source 
use the string optimization for map keys in the packet handler map
This commit is contained in:
Marten Seemann 2020-12-05 21:05:09 +07:00 • committed by GitHub
commit 31b05bc249
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packet_handler_map.go
View file

@ -150,32 +150,29 @@ func (h *packetHandlerMap) logUsage() {
} }
func (h *packetHandlerMap) Add(id protocol.ConnectionID, handler packetHandler) bool /* was added */ { func (h *packetHandlerMap) Add(id protocol.ConnectionID, handler packetHandler) bool /* was added */ {
sid := string(id)
h.mutex.Lock() h.mutex.Lock()
defer h.mutex.Unlock() defer h.mutex.Unlock()
if _, ok := h.handlers[sid]; ok { if _, ok := h.handlers[string(id)]; ok {
h.logger.Debugf("Not adding connection ID %s, as it already exists.", id) h.logger.Debugf("Not adding connection ID %s, as it already exists.", id)
return false return false
} }
h.handlers[sid] = handler h.handlers[string(id)] = handler
h.logger.Debugf("Adding connection ID %s.", id) h.logger.Debugf("Adding connection ID %s.", id)
return true return true
} }
func (h *packetHandlerMap) AddWithConnID(clientDestConnID, newConnID protocol.ConnectionID, fn func() packetHandler) bool { func (h *packetHandlerMap) AddWithConnID(clientDestConnID, newConnID protocol.ConnectionID, fn func() packetHandler) bool {
sid := string(clientDestConnID)
h.mutex.Lock() h.mutex.Lock()
defer h.mutex.Unlock() defer h.mutex.Unlock()
if _, ok := h.handlers[sid]; ok { if _, ok := h.handlers[string(clientDestConnID)]; ok {
h.logger.Debugf("Not adding connection ID %s for a new session, as it already exists.", clientDestConnID) h.logger.Debugf("Not adding connection ID %s for a new session, as it already exists.", clientDestConnID)
return false return false
} }
sess := fn() sess := fn()
h.handlers[sid] = sess h.handlers[string(clientDestConnID)] = sess
h.handlers[string(newConnID)] = sess h.handlers[string(newConnID)] = sess
h.logger.Debugf("Adding connection IDs %s and %s for a new session.", clientDestConnID, newConnID) h.logger.Debugf("Adding connection IDs %s and %s for a new session.", clientDestConnID, newConnID)
return true return true