mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 12:47:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

don't unlock the receive stream mutex for copying from STREAM frames

Browse source
This commit is contained in:
Marten Seemann 2021-10-16 17:45:43 +02:00
parent bb8d4844d5
commit 344feb9ea5
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
receive_stream.go
View file

@ -166,13 +166,10 @@ func (s *receiveStream) readImpl(p []byte) (bool /*stream completed */, int, err
return false, bytesRead, fmt.Errorf("BUG: readPosInFrame (%d) > frame.DataLen (%d) in stream.Read", s.readPosInFrame, len(s.currentFrame)) return false, bytesRead, fmt.Errorf("BUG: readPosInFrame (%d) > frame.DataLen (%d) in stream.Read", s.readPosInFrame, len(s.currentFrame))
} }
s.mutex.Unlock()
m := copy(p[bytesRead:], s.currentFrame[s.readPosInFrame:]) m := copy(p[bytesRead:], s.currentFrame[s.readPosInFrame:])
s.readPosInFrame += m s.readPosInFrame += m
bytesRead += m bytesRead += m
s.mutex.Lock()
// when a RESET_STREAM was received, the was already informed about the final byteOffset for this stream // when a RESET_STREAM was received, the was already informed about the final byteOffset for this stream
if !s.resetRemotely { if !s.resetRemotely {
s.flowController.AddBytesRead(protocol.ByteCount(m)) s.flowController.AddBytesRead(protocol.ByteCount(m))