mirrors/uquic
1
0
Fork 0
mirror of https://github.com/refraction-networking/uquic.git synced 2025-04-04 04:37:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

generate new connection ID after version negotiation

Browse source 
fixes #404
This commit is contained in:
Marten Seemann 2017-02-06 15:42:37 +07:00
parent 268841f0cc
commit 35242394e1
No known key found for this signature in database
GPG key ID: 3603F40B121FCDEA
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
client.go
View file

@ -175,9 +175,14 @@ func (c *Client) handlePacket(packet []byte) error {
return qerr.VersionNegotiationMismatch
}
utils.Infof("Switching to QUIC version %d", highestSupportedVersion)
// switch to negotiated version
c.version = highestSupportedVersion
c.versionNegotiated = true
c.connectionID, err = utils.GenerateConnectionID()
if err != nil {
return err
}
utils.Infof("Switching to QUIC version %d. New connection ID: %x", highestSupportedVersion, c.connectionID)
c.session.Close(errCloseSessionForNewVersion)
err = c.createNewSession(hdr.SupportedVersions)

2
client_test.go
View file

@ -211,12 +211,14 @@ var _ = Describe("Client", func() {
newVersion := protocol.Version35
Expect(newVersion).ToNot(Equal(client.version))
Expect(session.packetCount).To(BeZero())
client.connectionID = 0x1337
err := client.handlePacket(getVersionNegotiation([]protocol.VersionNumber{newVersion}))
Expect(client.version).To(Equal(newVersion))
Expect(client.versionNegotiated).To(BeTrue())
Expect(versionNegotiateCallbackCalled).To(BeTrue())
// it swapped the sessions
Expect(client.session).ToNot(Equal(session))
Expect(client.connectionID).ToNot(Equal(0x1337)) // it generated a new connection ID
Expect(err).ToNot(HaveOccurred())
// it didn't pass the version negoation packet to the session (since it has no payload)
Expect(session.packetCount).To(BeZero())